Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: One of the most common errors on API Docs appears to be ``` ServerException ServerException {serverException_message = "QualifiedName: Language unsupported: Language_Haskell"} 247 (0.4%) ``` 247 events in the last day. I don't fully understand how it could be so common, unless Haskell api pages are getting rendered in search results somewhere and failing. Somewhere along the line qnames became mandatory, instead of optional. So fix that. also fixes search : "No results found in symbol" in search, Haskell syms are still only discoverable by qname {F1761495551} the underlying problem is the hs.DefinitionName is a qname we need a dotted form with separate structured components. ``` fbsource.fbcode.haskell> hs.DefinitionName _ { "id": 88131, "key": "A.Types.A" } { "id": 61435, "key": "A.a" } { "id": 68899, "key": "A.main" } { "id": 82260, "key": "AardvarkTest.aardvarkCounter" } { "id": 82262, "key": "AardvarkTest.main" } { "id": 91585, "key": "Acl.Types.Identity" } { "id": 52655, "key": "AddPrefixTest.main" } { "id": 52661, "key": "AddPrefixTest.toPrefixedE" } { "id": 52659, "key": "AddPrefixTest.toPrefixedS" } { "id": 52657, "key": "AddPrefixTest.toPrefixedU" } { "id": 75973, "key": "AesonTest.main" } { "i ``` becomes: Reviewed By: simonmar Differential Revision: D59898073 fbshipit-source-id: 5f1851ca5350edf6d5ab60119be66da5feb1f7f8
- Loading branch information