Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glean][arm][oss][gh] Use an arm VM directly for CI #461

Closed

Conversation

donsbot
Copy link
Contributor

@donsbot donsbot commented Jul 18, 2024

The github provider arm64 runners don't have docker on them, so if we try to use a 'container' stanza to pick a particular linux version, we fail. We don't actually need to use a nested vm since the host is a ubuntu 22 image on arm64 anyway. So just run natively.

needs sudo passwordless for apt-get tho

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for fb-oss-glean canceled.

Name Link
🔨 Latest commit 9adf7cc
🔍 Latest deploy log https://app.netlify.com/sites/fb-oss-glean/deploys/669882a4319077000858e946

@donsbot donsbot force-pushed the dons-ci-arm-jul-18-24 branch 10 times, most recently from 81a7b39 to 317d061 Compare July 18, 2024 01:11
@donsbot donsbot changed the title [glean][arm][oss][gh] Use an arm image when using arm runners [glean][arm][oss][gh] Use an arm VM directly for CI Jul 18, 2024
Otherwise we would fail trying to set up docker on a bare arm linux
runner.

Notes:
- this runs directly on the provided runner (not a docker image, nesting)
- passwordless sudo
@donsbot donsbot force-pushed the dons-ci-arm-jul-18-24 branch from 317d061 to 9adf7cc Compare July 18, 2024 02:49
@facebook-github-bot
Copy link
Contributor

@donsbot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants