Add clang-15+ prerequisite to README #8203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Place that in https://github.com/facebookincubator/below/blob/main/docs/building.md instead? |
|
Makes sense (hoping people would read that before trying to build). |
|
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Yeah like Daniel said, let's add it to the dependencies section in building.md and also update the build instructions at the bottom. |
|
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@brianc118 merged this pull request in 6d3392d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues (#8112, #8195) have been created related to build errors because the build isn't using
clang-15or greater.