-
Notifications
You must be signed in to change notification settings - Fork 121
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace aggregate Jit/lir/lir.h with individual headers
Summary: This is a header that only contains #includes. We should break it up and have users pull in the exact headers they care about instead. Note: lir.h includes block.h, function.h, instruction.h, operand.h, and printer.h. Of these five, some of them include each other. operand.h doesn't include any of the others instruction.h includes operand.h block.h includes instruction.h function.h includes block.h printer.h includes function.h and others Thus, operand.h has the narrowest scope and printer.h has the biggest scope (it has everything). Therefore when I tested to see which of these five were necessary I started by adding all five and then removing the biggest scope ones first. This allows me to see if the biggest scope one has any essential use outside of the other header files it includes. These were the steps I took: 1. Add all 2. Remove printer.h 1. If fails remove the rest and just leave printer.h 3. Remove function.h 1. If it fails remove the rest and just leave function.h 4. Remove Block.h 1. If it fails remove the rest and just leave block.h 5. Remove Instruction.h 1. If it fails remove the rest and just leave instruction.h 6. Remove operand.h 1. If it fails remove the rest and just leave operand.h I checked failure by running OPT=-O2 Tools/scripts/facebook/configure_with_fb_toolchain.py --ccache --debug make -j make -j testruntime make -j testcinder make -j testcinder_jit Reviewed By: alexmalyshev Differential Revision: D52371303 fbshipit-source-id: 64b6766e4c199144444ebde4a7228c5638eb98c9
- Loading branch information
1 parent
3fddf3c
commit 85ae9e2
Showing
15 changed files
with
7 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters