Skip to content

Commit

Permalink
UnitLoader supports initial rowsToSkip (#48)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/velox#9703

Pull Request resolved: #48

Modify interface to accept rowsToSkip.

Readers will soon support it.

Reviewed By: Sullivan-Patrick

Differential Revision: D56953541

fbshipit-source-id: 8280a139347c60e5c918eb3bd817eb8295b2b19f
  • Loading branch information
Daniel Munoz authored and facebook-github-bot committed May 8, 2024
1 parent 75b3730 commit 010b35d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dwio/nimble/velox/VeloxReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -515,11 +515,11 @@ std::unique_ptr<velox::dwio::common::UnitLoader> VeloxReader::getUnitLoader() {
stripe, *tabletReader_, schema_, offsets_));
}
if (parameters_.unitLoaderFactory) {
return parameters_.unitLoaderFactory->create(std::move(units));
return parameters_.unitLoaderFactory->create(std::move(units), 0);
}
velox::dwio::common::OnDemandUnitLoaderFactory factory(
parameters_.blockedOnIoCallback);
return factory.create(std::move(units));
return factory.create(std::move(units), 0);
}

uint32_t VeloxReader::getUnitIndex(uint32_t stripeIndex) const {
Expand Down

0 comments on commit 010b35d

Please sign in to comment.