Skip to content

Commit

Permalink
Fix velox_query_replayer linking error (#11388)
Browse files Browse the repository at this point in the history
Summary:
A follow-up fix PR for #11360 to address the linking error:

```cmake
[1432/1435] Linking CXX executable velox/tool/trace/velox_query_replayer
FAILED: velox/tool/trace/velox_query_replayer
...
Undefined symbols for architecture arm64:
  "facebook::velox::tool::trace::TraceReplayRunner::run()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::init()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "facebook::velox::tool::trace::TraceReplayRunner::TraceReplayRunner()", referenced from:
      _main in TraceReplayerMain.cpp.o
  "vtable for facebook::velox::tool::trace::TraceReplayRunner", referenced from:

Reviewed By: xiaoxmeng

Differential Revision: D65217021

Pulled By: kgpai

fbshipit-source-id: 2e0e44d916a27853366d77d883f0add70993fdc0
  • Loading branch information
zuyu authored and facebook-github-bot committed Oct 30, 2024
1 parent df5cff5 commit 11e4a8e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion velox/tool/trace/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ velox_add_library(
AggregationReplayer.cpp
OperatorReplayerBase.cpp
PartitionedOutputReplayer.cpp
TableWriterReplayer.cpp)
TableWriterReplayer.cpp
TraceReplayRunner.cpp)

velox_link_libraries(
velox_query_trace_replayer_base
Expand Down

0 comments on commit 11e4a8e

Please sign in to comment.