Skip to content

Commit

Permalink
Fix adapters dockerfile classpath script name (#11132)
Browse files Browse the repository at this point in the history
Summary:
A new script to setup the classpath was added by PR [10446](#10446) that is called incorrectly on startup of the container.
The name needs to be setup-classpath.sh and not set_classpath.sh.

Error returned on startup
[root@czentgr-foobar velox]# docker run -it 64a9eed9f771 bash Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg. --: line 1: /set_classpath.sh: No such file or directory

Pull Request resolved: #11132

Reviewed By: pedroerp

Differential Revision: D63648777

Pulled By: kagamiori

fbshipit-source-id: 6ce0a4a32f22e5729e7a98feac5a45629c83b4b8
  • Loading branch information
czentgr authored and facebook-github-bot committed Sep 30, 2024
1 parent 92779f9 commit 40f32ea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/adapters.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN mkdir build && ( cd build && source /opt/rh/gcc-toolset-12/enable && \
RUN curl -L -o /tmp/miniforge.sh https://github.com/conda-forge/miniforge/releases/download/23.11.0-0/Mambaforge-23.11.0-0-Linux-x86_64.sh && \
bash /tmp/miniforge.sh -b -p /opt/miniforge && \
rm /tmp/miniforge.sh
ENV PATH=/opt/miniforge/condabin:${PATH}
ENV PATH=/opt/miniforge/condabin:${PATH}

# install test dependencies
RUN mamba create -y --name adapters python=3.8
Expand All @@ -42,5 +42,5 @@ ENV HADOOP_HOME=/usr/local/hadoop \
PATH=/usr/lib/jvm/java-1.8.0-openjdk/bin:${PATH}

COPY scripts/setup-classpath.sh /
ENTRYPOINT ["/bin/bash", "-c", "source /set_classpath.sh && source /opt/rh/gcc-toolset-12/enable && exec \"$@\"", "--"]
ENTRYPOINT ["/bin/bash", "-c", "source /setup-classpath.sh && source /opt/rh/gcc-toolset-12/enable && exec \"$@\"", "--"]
CMD ["/bin/bash"]

0 comments on commit 40f32ea

Please sign in to comment.