-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow empty seconds when parsing timestamps strings (#9401)
Summary: Following Presto semantics, seconds are allowed to be empty when parsing timestamp strings. For example, both formats should be allowed: > 2024-01-01 00:00:00 > 2024-01-01 00:00 It is an open question whether we want to change it only for Preto string to timestamp casts, or across the board. This PR changes for all conversions since this seems pretty harmless (and intuitive). Also fixing a small bug: "00:00:00." shouldn't be allowed. Reviewed By: mbasmanova Differential Revision: D55831722
- Loading branch information
1 parent
f51e34d
commit 4366298
Showing
3 changed files
with
42 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters