Improve echo

facebookincubator · Mar 2, 2024 · 4ae3ada · 4ae3ada
1 parent 77b538c
commit 4ae3ada
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/scripts/setup-centos8.sh b/scripts/setup-centos8.sh
@@ -213,6 +213,7 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
@@ -222,9 +223,8 @@ function install_velox_deps {
     source /opt/rh/gcc-toolset-9/enable || exit 1
     set -u
     install_velox_deps
+    echo "All dependencies for Velox installed!"
+    dnf clean all
   fi
 )
 
-echo "All dependencies for Velox installed!"
-
-dnf clean all
diff --git a/scripts/setup-macos.sh b/scripts/setup-macos.sh
@@ -147,15 +147,16 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
       run_and_time install_build_prerequisites
     fi
     install_velox_deps
+    echo "All deps for Velox installed! Now try \"make\""
   fi
 )
 
-echo "All deps for Velox installed! Now try \"make\""
 echo 'To add cmake-format bin to your $PATH, consider adding this to your ~/.profile:'
 echo 'export PATH=$HOME/bin:$HOME/Library/Python/3.7/bin:$PATH'
diff --git a/scripts/setup-ubuntu.sh b/scripts/setup-ubuntu.sh
@@ -89,7 +89,6 @@ function install_velox_deps_from_apt {
     tzdata
 }
 
-# Install all velox dependencies.
 function install_fmt {
   github_checkout fmtlib/fmt "${FMT_VERSION}"
   cmake_install -DFMT_TEST=OFF
@@ -161,13 +160,14 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
       run_and_time install_build_prerequisites
     fi
     install_velox_deps
+    echo "All dependencies for Velox installed!"
   fi
 )
 
-echo "All dependencies for Velox installed!"