Ensure that server logs are archived.

facebookincubator · Jan 11, 2024 · 5193e7f · 5193e7f
1 parent 57d8781
commit 5193e7f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/experimental.yml b/.github/workflows/experimental.yml
@@ -117,7 +117,11 @@ jobs:
 
       - name: "Run Aggregate Fuzzer"
         run: |
-          /opt/start-prestojava.sh 2>&1 >> /tmp/server.log &
+          ls -lR $PRESTO_HOME/etc
+          /opt/start-prestojava.sh > /tmp/server.log 2>&1 &
+          sleep 60
+          echo 'CREATE SCHEMA hive.tpch;' > /tmp/hive_create.sql
+          /opt/presto-cli --server 127.0.0.1:8080 --file /tmp/hive_create.sql
           mkdir -p /tmp/aggregate_fuzzer_repro/
           rm -rfv /tmp/aggregate_fuzzer_repro/*
           chmod -R 777 /tmp/aggregate_fuzzer_repro
@@ -139,6 +143,7 @@ jobs:
           name: aggregate-fuzzer-failure-artifacts
           path: |
             /tmp/aggregate_fuzzer_repro
+            /tmp/server.log
 
   linux-spark-fuzzer-run:
     runs-on: ubuntu-latest

diff --git a/scripts/prestojava-container.dockerfile b/scripts/prestojava-container.dockerfile
@@ -40,7 +40,6 @@ RUN dnf install -y java-11-openjdk less procps python3 tzdata \
     && mkdir -p /usr/lib/presto/utils
 
 
-# Setting timezone to deal with Velox timezone conversion problem
 ENV TZ=America/Bahia_Banderas
 
 COPY scripts/etc/config.properties.example $PRESTO_HOME/etc/config.properties

diff --git a/scripts/start-prestojava.sh b/scripts/start-prestojava.sh
@@ -15,8 +15,5 @@
 
 set -e
 
-nohup $PRESTO_HOME/bin/launcher --pid-file=/tmp/pidfile  run >  /tmp/server.log
-#wait a few seconds for presto to start
-sleep 60
-echo 'CREATE SCHEMA hive.tpch;' > /tmp/hive_create.sql
-/opt/presto-cli --server 127.0.0.1:8080 --file /tmp/hive_create.sql
+$PRESTO_HOME/bin/launcher --pid-file=/tmp/pidfile  run
+