move clearNull

facebookincubator · Oct 28, 2023 · 78d847a · 78d847a
1 parent 27986d7
commit 78d847a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/velox/functions/sparksql/aggregates/DecimalSumAggregate.h b/velox/functions/sparksql/aggregates/DecimalSumAggregate.h
@@ -130,11 +130,11 @@ class DecimalSumAggregate : public exec::Aggregate {
 
     for (auto i = 0; i < numGroups; ++i) {
       char* group = groups[i];
+      clearNull(rawNulls, i);
       if (isNull(group)) {
         rawSums[i] = 0;
         bits::setBit(rawIsEmpty, i, true);
       } else {
-        clearNull(rawNulls, i);
         auto* decimalSum = accumulator(group);
         bool overflow = false;
         auto result = (TResultType)computeFinalValue(decimalSum, overflow);