Skip to content

Commit

Permalink
migrate from exception_wrapper from_catch_ref ctor (assorted) (#8082)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #8082

Migrate sites which call the `from_catch_ref` ctor of `folly::exception_wrapper`, merging otherwise-equivalent cases or otherwise simplifying code where possible.

Reviewed By: anps77

Differential Revision: D52046402

fbshipit-source-id: 21be7464d2bbe05626506d6cf987df4b4bfe6ca5
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Dec 17, 2023
1 parent a2d7ae2 commit afaaef3
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions velox/dwio/common/ExecutorBarrier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ auto ExecutorBarrier::wrapMethod(folly::Func f) {
barrierElement = BarrierElement(count_, mutex_, cv_)]() mutable {
try {
f();
} catch (const std::exception& e) {
std::lock_guard lock{mutex_};
if (!exception_.has_exception_ptr()) {
exception_ = folly::exception_wrapper(
::folly::exception_wrapper::from_catch_ref_t{},
std::current_exception(),
e);
}
} catch (...) {
std::lock_guard lock{mutex_};
if (!exception_.has_exception_ptr()) {
Expand Down

0 comments on commit afaaef3

Please sign in to comment.