fix empty delim case

facebookincubator · Jun 19, 2024 · c38458a · c38458a
1 parent 9196ebc
commit c38458a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/velox/functions/sparksql/SplitFunctions.cpp b/velox/functions/sparksql/SplitFunctions.cpp
@@ -115,7 +115,7 @@ class Split final : public exec::VectorFunction {
         offset += 1;
       }
 
-      if (offset > input.size()) {
+      if (offset >= input.size()) {
         break;
       }
 

diff --git a/velox/functions/sparksql/tests/SplitFunctionsTest.cpp b/velox/functions/sparksql/tests/SplitFunctionsTest.cpp
@@ -249,8 +249,8 @@ TEST_F(SplitTest, split) {
   // Check the empty delimiter special case.
   delim = "";
   auto expected = makeArrayVector<StringView>({
-      {"I", ",", "h", "e", ",", "s", "h", "e", ",", "t", "h", "e", "y", ""},
-      {"o", "n", "e", ",", ",", ",", "f", "o", "u", "r", ",", ""},
+      {"I", ",", "h", "e", ",", "s", "h", "e", ",", "t", "h", "e", "y"},
+      {"o", "n", "e", ",", ",", ",", "f", "o", "u", "r", ","},
       {""},
   });
   assertEqualVectors(expected, run(inputStrings, delim, "split(C0, C1)"));
-Original file line number
+Diff line change
@@ Expand Up / @@ -115,7 +115,7 @@ class Split final : public exec::VectorFunction { @@
             offset += 1;
           }
-          if (offset > input.size()) {
+          if (offset >= input.size()) {
             break;
           }
@@ Expand Down @@