Allow decimal types in switch expr

facebookincubator · Oct 16, 2023 · d46709e · d46709e
1 parent 94917a5
commit d46709e
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/velox/expression/SwitchExpr.cpp b/velox/expression/SwitchExpr.cpp
@@ -49,11 +49,16 @@ SwitchExpr::SwitchExpr(
 
   // Apply type checking.
   auto typeExpected = resolveType(inputTypes);
-  VELOX_CHECK(
-      *typeExpected == *this->type(),
-      "Switch expression type different than then clause. Expected {} but got Actual {}.",
-      typeExpected->toString(),
-      this->type()->toString());
+  if (elseClauseType->isDecimal()) {
+    // Regard decimal types as the same regardless of precision and scale.
+    VELOX_CHECK(expressionType->isDecimal());
+  } else {
+    VELOX_CHECK(
+        *typeExpected == *this->type(),
+        "Switch expression type different than then clause. Expected {} but got Actual {}.",
+        typeExpected->toString(),
+        this->type()->toString());
+  }
 }
 
 void SwitchExpr::evalSpecialForm(