rebase

facebookincubator · Oct 3, 2023 · fdaf27d · fdaf27d
1 parent e1fcaa5
commit fdaf27d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/velox/functions/sparksql/aggregates/DecimalSumAggregate.h b/velox/functions/sparksql/aggregates/DecimalSumAggregate.h
@@ -72,7 +72,7 @@ class DecimalSumAggregate : public exec::Aggregate {
 
     auto [resultPrecision, resultScale] =
         getDecimalPrecisionScale(*sumType_.get());
-    overflow = !DecimalUtil::valueInRangeWithPrecision(sum, resultPrecision);
+    overflow = !DecimalUtil::valueInPrecisionRange(sum, resultPrecision);
     return sum;
   }
 
@@ -131,7 +131,8 @@ class DecimalSumAggregate : public exec::Aggregate {
     for (auto i = 0; i < numGroups; ++i) {
       char* group = groups[i];
       if (isNull(group)) {
-        rowVector->setNull(i, true);
+        rawSums[i] = 0;
+        bits::setBit(rawIsEmpty, i, true);
       } else {
         clearNull(rawNulls, i);
         auto* decimalSum = accumulator(group);