Fix hashOne functions in HivePartitionFunction #10079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@Yuhta can you please review this? We need this to merge the Centos9 upgrade. Thanks! |
Yuhta
reviewed
Jun 6, 2024
| @@ -76,7 +76,9 @@ inline uint32_t hashOne<TypeKind::INTEGER>(const int32_t& value) { | |||
|
|
|||
| template <> | |||
| inline uint32_t hashOne<TypeKind::REAL>(const float& value) { | |||
| return static_cast<uint32_t>(*reinterpret_cast<const int32_t*>(&value)); | |||
| uint32_t ret; | |||
| memcpy(&ret, &value, sizeof ret); | |||
There was a problem hiding this comment.
Can you just fix the signature of hashOne to pass by value?
There was a problem hiding this comment.
I believe just fixing the signature is enough without the std::memcpy. This should not have any strict aliasing issues.
majetideepak
force-pushed
the
fix-hash-partition-functions
branch
from
801933d to
5f1796f
Compare
majetideepak
changed the title
Yuhta
approved these changes
Jun 6, 2024
Yuhta
added
the
ready-to-merge
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kevinwilfong merged this pull request in 1c0df40. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
Summary: Pass by value to avoid strict aliasing issues for REAL and DOUBLE types. We are seeing the HivePartitionFunctionTest failing with GCC12 here facebookincubator#9903 Pull Request resolved: facebookincubator#10079 Reviewed By: Yuhta Differential Revision: D58294082 Pulled By: kevinwilfong fbshipit-source-id: 765af472a35d1f8f2b619d5c58ee4399a8359ee2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass by value to avoid strict aliasing issues for REAL and DOUBLE types.
We are seeing the HivePartitionFunctionTest failing with GCC12 here #9903