Add helper function to return the number of days since epoch for a week-of-month date #10604

NEUpanning · 2024-07-30T07:10:32Z

This helper function is only used by Spark. To align with Spark's SimpleDateFormat behavior, this function offers two modes: lenient and non-lenient. For non-lenient mode, it returns an error status if the date is invalid. For lenient mode, it accepts a wider range of arguments.

Part of #10511

netlify · 2024-07-30T07:10:50Z

✅ Deploy Preview for meta-velox ready!

Name	Link
🔨 Latest commit	`935bab1`
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/66d6b68bb20ebd0008f2ef13
😎 Deploy Preview	https://deploy-preview-10604--meta-velox.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mbasmanova

Thank you for extracting this logic into a separate PR.

The PR title mentions "date format", but the code doesn't seem to be dealing with date format. Wondering if the PR title / description could be updated for clarity and accuracy.

CC: @rui-mo

velox/type/TimestampConversion.h

mbasmanova · 2024-07-30T07:19:51Z

velox/type/TimestampConversion.cpp

+  int64_t daysSinceEpochOfFirstDayOfMonth;
+  VELOX_RETURN_NOT_OK(
+      daysSinceEpochFromDate(year, month, 1, daysSinceEpochOfFirstDayOfMonth));
+  int32_t firstDayOfWeek =


I believe I asked this earlier, but I don't think I saw an answer, hence, asking again. What happens if weekOfMonth is 5, but month has only 4 weeks (Feb)? Similarly, what happens if weekOfMonth is 5 and dayOfWeek is 7 (no month has 35 days)?

In Java's SimpleDateFormat, "invalid" weekOfMonth and dayOfWeek etc. are allowed. If the date falls outside the valid range, the week or day from the preceding or following month's will be used. For example, if weekOfMonth is 5 but the current month only has 4 weeks (such as February), the first week of March will be considered as the 5th week of February. Similarly, if weekOfMonth is 5 and dayOfWeek is 7, the corresponding day from the next month will be used.

Thank you for clarifying. Let's update method comments to explain this as it is not obvious. Do we already have tests for these cases? If not, let's make sure to add.

I added this comments for clarifying and two tests for cases that days in previous/next month.

We treat days of the previous or next months as a part of the specified WEEK_OF_MONTH. For example, if
weekOfMonth is 5 but the current month only has 4 weeks (such as February),the first week of March will be considered as the 5th week of February.

I'm seeing that DATE type is based on INTEGER type, hence, allows only int32_t number of days since epoch. If that's the case, then, perhaps, daysSinceEpochFromDate should return int32_t, not int64_t.

This PR is intended for date parsing, and the DateTimeFormatter::parse method returns a Timestamp. A Timestamp is based on int64_t seconds and can represent up to 106,751,991,167 days, which is calculated as (2^63 - 1) / 1000 / 86400. This value is greater than the maximum value of an int32_t. Therefore, I think that daysSinceEpochFromDate should return an int64_t.

NEUpanning · 2024-07-30T09:00:24Z

@mbasmanova I have updated the PR title and description to remove the words related to "date format"

rui-mo

Thanks. Added several comments.

rui-mo · 2024-07-30T09:30:21Z

velox/type/TimestampConversion.cpp

@@ -144,6 +144,26 @@ bool isValidWeekDate(int32_t weekYear, int32_t weekOfYear, int32_t dayOfWeek) {
  return true;
 }

+bool isValidWeekOfMonthDate(


According to the discussion at https://github.com/facebookincubator/velox/pull/10511/files#r1686566980, true result does not always indicate a valid date.

If the date falls outside the valid range, the week or day from the preceding or following month's will be used.

With current implementation, for some invalid date, we return user error status while for the others we return a int64_t result in the daysSinceEpochFromWeekOfMonthDate function, which seems to be confusing.

I notice the method isValidDate provides an accurate evaluation for valid date. Does it make sense to use that?
https://github.com/facebookincubator/velox/blob/main/velox/type/TimestampConversion.cpp#L518-L529

You are right. We should remove the validation for week of month. According to SimpleDateFormat's doc the range of day is [1,7] so isValidDate isn't suitable for this.

u | Day number of week (1 = Monday, ..., 7 = Sunday) | Number | 1

Done. See e718074

According to SimpleDateFormat's doc the range of day is [1,7] so isValidDate isn't suitable for this.

Could you clarify the purpose of isValidWeekOfMonthDate? Is it to follow certain rule defined in SimpleDateFormat to check if a date is valid, and what are the rules? Perhaps add some comments for this function.

I want to do validation follows SimpleDateFormat. However, SimpleDateFormat does not provide clear rules or relevant documentation. For example, document states WEEK_OF_MONTH field range is from 0 to 6, , but in my tests, a value of 99 is considered valid.(https://github.com/facebookincubator/velox/pull/10511/files#r1686566980)

Values calculated for the WEEK_OF_MONTH field range from 0 to 6

Another example is the valid range for the year field, which is not documented.

I tried to determine the valid range through testing, but it is too costly and not reliable enough. I wonder how to properly validate dates in Velox. Could you give me some advice?

@rui-mo I don't believe this functionality is needed for Presto functions. Hence, we are free to define semantics in any "sensible" way. Assuming we need these semantics to match Spark, we can use Spark semantics.

Thanks for the pointer. Understood.

@mbasmanova @rui-mo According to this discussion, Spark date validation rules in document don't match with the test results. Which one should I follow? Thanks.

@NEUpanning I assume we need to follow the actual behavior of Spark. How do you think?

@rui-mo I agree with you. I will change the part of date validation for following the actual behavior of Spark.

velox/type/TimestampConversion.cpp

rui-mo · 2024-07-30T09:37:55Z

velox/type/TimestampConversion.cpp

+    return folly::makeUnexpected(status);
+  }
+  int32_t firstDayOfWeek =
+      extractISODayOfTheWeek(daysSinceEpochOfFirstDayOfMonth);


extractISODayOfTheWeek accepts an int32_t value while the input is of int64_t type. Shall we check for overflow?

I notice extractISODayOfTheWeek casts input to int64_t. How about changing parameter to int64_t type instead of int32_t type

Looks like the cast is to avoid overflow in addition and negating. If we change it as int64_t, overflow needs to considered as well by casting to a larger type.

Thanks for your explanation. I see daysSinceEpochFromWeekDate function also calls this funtion with a int64_t argument. I think we change extractISODayOfTheWeek parameter to int64_t and cast it to int128_t when do calculate would be better. How do you think?

I wonder if there is any limitation for year? If the days cannot exceed INT32_MAX, it would be safe to call it.

The max year is 292278994 so the days can be (292278994-1970)*365=106,681,113,760 that is bigger than 2,147,483,647(INT32_MAX).

I think we change extractISODayOfTheWeek parameter to int64_t and cast it to int128_t when do calculate

Looks fine to me. @mbasmanova What are your thoughts? Thanks.

velox/type/TimestampConversion.h

velox/type/tests/TimestampConversionTest.cpp

velox/type/TimestampConversion.h

velox/type/TimestampConversion.cpp

mbasmanova · 2024-08-01T08:17:42Z

velox/type/TimestampConversion.h

@@ -107,6 +107,24 @@ Status daysSinceEpochFromWeekDate(
    int32_t dayOfWeek,
    int64_t& out);

+/// Computes the (signed) number of days since unix epoch (1970-01-01).
+/// Returns error status if the date is invalid. We treat days of the previous
+/// or next months as a part of the specified WEEK_OF_MONTH. For example, if


WEEK_OF_MONTH -> weekOfMonth for consistency

Thanks. Done.

mbasmanova · 2024-08-01T08:19:13Z

velox/type/TimestampConversion.h

+/// Returns error status if the date is invalid. We treat days of the previous
+/// or next months as a part of the specified WEEK_OF_MONTH. For example, if
+/// weekOfMonth is 5 but the current month only has 4 weeks (such as February),
+/// the first week of March will be considered as the 5th week of February.


Nice clarification. Perhaps, clarify that the same applies to dayOfWeek.

BTW, I assume you are matching some behavior from Spark here? It would be nice to clarify that to explain the choice of handling "overflow" dates. Do you have a link to Spark's documentation that explains these rules? Let's make sure we match exactly.

Yes, the implemention align with Spark's SimpleDateFormat. I've added docs. You can see the rules in this link.

Leniency
Calendar has two modes for interpreting the calendar fields, lenient and non-lenient. When a Calendar is in lenient mode, it accepts a wider range of calendar field values than it produces. When a Calendar recomputes calendar field values for return by get(), all of the calendar fields are normalized. For example, a lenient GregorianCalendar interprets MONTH == JANUARY, DAY_OF_MONTH == 32 as February 1.
When a Calendar is in non-lenient mode, it throws an exception if there is any inconsistency in its calendar fields. For example, a GregorianCalendar always produces DAY_OF_MONTH values between 1 and the length of the month. A non-lenient GregorianCalendar throws an exception upon calculating its time or calendar field values if any out-of-range field value has been set.

mbasmanova · 2024-08-01T08:20:11Z

velox/type/TimestampConversion.h

+/// @param dayOfWeek Day number of week. A value in [1, 7] range. For example, 1
+/// is Monday, 7 is Sunday.
+Expected<int64_t> daysSinceEpochFromWeekOfMonthDate(
+    int32_t year,


The implementation imposes limits on the 'year' value. Would you document these?

Thanks. Done.

mbasmanova · 2024-08-01T08:27:09Z

velox/type/TimestampConversion.cpp

+  int64_t daysSinceEpochOfFirstDayOfMonth;
+  VELOX_RETURN_NOT_OK(
+      daysSinceEpochFromDate(year, month, 1, daysSinceEpochOfFirstDayOfMonth));
+  int32_t firstDayOfWeek =


I'm seeing that DATE type is based on INTEGER type, hence, allows only int32_t number of days since epoch. If that's the case, then, perhaps, daysSinceEpochFromDate should return int32_t, not int64_t.

mbasmanova · 2024-08-01T08:27:47Z

velox/type/tests/TimestampConversionTest.cpp

@@ -104,6 +104,39 @@ TEST(DateTimeUtilTest, fromDateInvalid) {
      1970, 6, 31, "Date out of range: 1970-6-31"));
 }

+TEST(DateTimeUtilTest, fromWeekOfMonthDate) {
+  auto daysSinceEpochFromWeekOfMonthDate =


nit: consider shortening to daysSinceEpoch for readability

Thanks. Done

mbasmanova · 2024-08-01T08:28:41Z

velox/type/tests/TimestampConversionTest.cpp

+  // day in previous month
+  EXPECT_EQ(19783, daysSinceEpochFromWeekOfMonthDate(2024, 2, 5, 5));
+  // day in next month
+  EXPECT_EQ(19751, daysSinceEpochFromWeekOfMonthDate(2024, 2, 1, 1));


Would you add negative tests to verify logic in isValidWeekOfMonthDate?

Thanks. I added fromWeekOfMonthDateInvalid tests.

mbasmanova · 2024-08-01T08:29:05Z

velox/type/tests/TimestampConversionTest.cpp

+  EXPECT_EQ(-719561, daysSinceEpochFromWeekOfMonthDate(-1, 12, 1, 1));
+  EXPECT_EQ(-719897, daysSinceEpochFromWeekOfMonthDate(-1, 1, 1, 1));
+
+  // day in previous month


nit: Make sure comments are full sentences. Start with a capital letter. End with a period.

Thanks. Done.

mbasmanova · 2024-08-01T08:33:01Z

velox/type/tests/TimestampConversionTest.cpp

+  EXPECT_EQ(-719533, daysSinceEpochFromWeekOfMonthDate(0, 1, 1, 1));
+
+  // Negative year - BC.
+  EXPECT_EQ(-719561, daysSinceEpochFromWeekOfMonthDate(-1, 12, 1, 1));


I wonder if it would be easier to maintain these tests if we use date strings for 'expected' value.

EXPECT_EQ(parseDate("-1-12-01"), daysSinceEpoch(-1, 12, 1, 1) EXPECT_EQ(parseDate("2024-03-05"), daysSinceEpoch(2024, 2, 5, 5));

Thanks for your suggestion. In this way, if the test fails, it could be an issue with parseDate. And I'm not sure the behavior of parseDate is same as daysSinceEpochFromWeekOfMonthDate.

NEUpanning · 2024-08-15T09:23:34Z

@mbasmanova @rui-mo I took some time to read the Java SimpleDateFormat code used by Spark to better understand its actual behavior. I've updated the branch accordingly. Looking forward to your review.

rui-mo

Thanks. Looks much better now. Some comments.

velox/type/TimestampConversion.h

velox/type/TimestampConversion.cpp

velox/type/tests/TimestampConversionTest.cpp

velox/type/TimestampConversion.h

NEUpanning · 2024-08-23T03:54:14Z

@rui-mo I've updated the code based on the review. Thanks.

velox/type/tests/TimestampConversionTest.cpp

rui-mo

Would you also resolve the code format issue? Thanks.

velox/type/TimestampConversion.cpp

velox/type/tests/TimestampConversionTest.cpp

NEUpanning · 2024-08-26T06:20:28Z

@rui-mo I've resolved format issue and review comments. Thanks.

rui-mo · 2024-08-27T05:05:10Z

cc: @mbasmanova Do you have any more comment? Thanks.

mbasmanova

@NEUpanning Would you update description to provide more context. There was a lot of discussion and on that PR. It would be nice to summarize the outcome.

mbasmanova

@NEUpanning Overall looks great. Some comments.

mbasmanova · 2024-08-29T10:38:39Z

velox/type/TimestampConversion.h

+/// modes: lenient and non-lenient. For non-lenient mode, it returns an error
+/// status if the date is invalid. For lenient mode, it accepts a wider range of
+/// arguments.
+/// @param year Year. For non-lenient mode, it should be in the range [1,


it should be in the range [1, 292278994]. e.g: 1996, -2000.

typo? The range doesn't seem to allow negative values or zero.

Not a typo. The min value of year in non-lenient mode is 1. Here is Java implementation:

static final int MIN_VALUES[] = {
BCE, // ERA
1, // YEAR
JANUARY, // MONTH
1, // WEEK_OF_YEAR
0, // WEEK_OF_MONTH
1, // DAY_OF_MONTH
1, // DAY_OF_YEAR
SUNDAY, // DAY_OF_WEEK
1, // DAY_OF_WEEK_IN_MONTH
AM, // AM_PM
0, // HOUR
0, // HOUR_OF_DAY
0, // MINUTE
0, // SECOND
0, // MILLISECOND
-13*ONE_HOUR, // ZONE_OFFSET (UNIX compatibility)
0 // DST_OFFSET
};

@NEUpanning Got it. In this case "e.g: 1996, -2000." needs updating since -2000 is not allowed.

It might be helpful to re-iterate that dates before Jan 1, 1970 are not supported in non-lenient mode.

I find it hard to say / write non-lenient. Would it make sense to flip the boolean to 'strict' mode?

@mbasmanova I assume using non-lenient is clearer because it indicates we only have tow modes. If using strict, readers might wonder if there is a balanced or moderate mode.

I'm not sure I follow. I was suggesting to consider replacing 'lenient' boolean with 'strict'.

Spark uses the term 'lenient', and this function aligns with Spark. See link. Therefore, I think 'lenient' would be more appropriate.

@NEUpanning I assume this suggestion is about replacing 'non-lenient' with 'strict' which makes it more straightforward to understand. The 'lenient' will stay unchanged.

@rui-mo

I assume using non-lenient is clearer because it indicates we only have tow modes. If using strict, readers might wonder if there is a balanced or moderate mode.

This is my concern. If this is not a problem or rarely happens, I'd like to replace it.

@NEUpanning Since it has been clarified in the comment that there are only two modes, so I think it is fine. Thanks.

Thanks for your suggestion. I've replaced it.

velox/type/TimestampConversion.h

velox/type/TimestampConversion.cpp

velox/type/tests/TimestampConversionTest.cpp

mbasmanova · 2024-08-29T10:53:22Z

velox/type/tests/TimestampConversionTest.cpp

+  // Out of range year.
+  auto result =
+      util::daysSinceEpochFromWeekOfMonthDate(292278995, 1, 1, 1, true);
+  EXPECT_EQ(result.error().message(), "Date out of range: 292278995-1-1");


I thought we do not expect errors in lenient mode. This behavior doesn't seem to match the doc. Would you double check?

You can see this conversation #10604 (comment). Maybe I should change the documentation.

mbasmanova · 2024-08-29T10:53:34Z

velox/type/tests/TimestampConversionTest.cpp

+  EXPECT_EQ(result.error().message(), "Date out of range: 292278995-1-1");
+}
+
+TEST(DateTimeUtilTest, extractISODayOfTheWeek) {


Any particular reason this tests is added in this PR?

This function extractISODayOfTheWeek is changed. See this discussion:#10604 (comment)

velox/type/tests/TimestampConversionTest.cpp

NEUpanning · 2024-08-30T02:30:10Z

@mbasmanova I've updated description and code. Could you review again? Thanks.

mbasmanova · 2024-08-30T04:40:19Z

@mbasmanova I've updated description and code. Could you review again? Thanks.

Have you published the changes? For some reason, I don't see these.

NEUpanning · 2024-08-30T06:59:10Z

@mbasmanova I didn't notice you have reviewed the changes in lastday. I've updated again. Thanks.

mbasmanova

Thanks.

facebook-github-bot · 2024-08-30T16:37:24Z

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

NEUpanning · 2024-09-03T09:51:27Z

@mbasmanova @rui-mo Could you help to merge this PR? Thanks.

mbasmanova · 2024-09-03T12:11:24Z

@bikramSingh91 Bikram, would you help merge this PR?

facebook-github-bot · 2024-09-04T16:58:26Z

@bikramSingh91 merged this pull request in fe7fdac.

conbench-facebook · 2024-09-04T17:46:16Z

Conbench analyzed the 1 benchmark run on commit fe7fdac5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

NEUpanning added 2 commits July 30, 2024 15:02

support daysSinceEpochFromWeekOfMonthDate

6104fc6

add unit tests

1d4667b

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2024

NEUpanning mentioned this pull request Jul 30, 2024

Add support for "week of month" in date parsing pattern #10511

Closed

reformat

e4b2c78

mbasmanova reviewed Jul 30, 2024

View reviewed changes

NEUpanning added 5 commits July 30, 2024 16:40

add argument doc

b4504f8

add argument doc

e9be740

update argument doc

a4ff46c

refactor with velox::Expected

555e1d9

reformat

83301ab

NEUpanning changed the title ~~Add support for getting the number of days since epoch from week of month date format~~ Add support for getting the number of days since epoch from week of month date Jul 30, 2024

rui-mo reviewed Jul 30, 2024

View reviewed changes

mbasmanova changed the title ~~Add support for getting the number of days since epoch from week of month date~~ Add helper function to return the number of days since epoch for a week-of-month date Jul 30, 2024

mbasmanova reviewed Jul 30, 2024

View reviewed changes

velox/type/TimestampConversion.h Outdated Show resolved Hide resolved

velox/type/TimestampConversion.h Outdated Show resolved Hide resolved

velox/type/TimestampConversion.cpp Outdated Show resolved Hide resolved

NEUpanning added 2 commits July 31, 2024 17:53

remove week validation

e718074

change after cr

9ce7750

mbasmanova reviewed Aug 1, 2024

View reviewed changes

add lenient and ut

216a000

rui-mo reviewed Aug 16, 2024

View reviewed changes

velox/type/TimestampConversion.cpp Show resolved Hide resolved

NEUpanning added 2 commits August 16, 2024 16:00

changes after ut

e850388

spotless

cb45539

rui-mo reviewed Aug 19, 2024

View reviewed changes

velox/type/TimestampConversion.cpp Show resolved Hide resolved

rui-mo reviewed Aug 19, 2024

View reviewed changes

velox/type/tests/TimestampConversionTest.cpp Show resolved Hide resolved

velox/type/tests/TimestampConversionTest.cpp Outdated Show resolved Hide resolved

velox/type/TimestampConversion.h Outdated Show resolved Hide resolved

NEUpanning added 2 commits August 19, 2024 16:53

naming

a98fedd

naming cmt

6135991

rui-mo reviewed Aug 23, 2024

View reviewed changes

velox/type/tests/TimestampConversionTest.cpp Outdated Show resolved Hide resolved

update

7a52b45

rui-mo reviewed Aug 26, 2024

View reviewed changes

velox/type/TimestampConversion.cpp Outdated Show resolved Hide resolved

velox/type/tests/TimestampConversionTest.cpp Outdated Show resolved Hide resolved

update

7d72017

rui-mo approved these changes Aug 27, 2024

View reviewed changes

NEUpanning requested a review from mbasmanova August 29, 2024 09:45

mbasmanova reviewed Aug 29, 2024

View reviewed changes

NEUpanning added 2 commits August 29, 2024 20:37

changes

3e2fb0c

changes

0fcb111

NEUpanning added 2 commits August 30, 2024 14:55

changes

0d29272

reformat

9267d21

mbasmanova approved these changes Aug 30, 2024

View reviewed changes

mbasmanova added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Aug 30, 2024

non-lenient -> strict

935bab1

facebook-github-bot closed this in fe7fdac Sep 4, 2024

facebook-github-bot added the Merged label Sep 4, 2024

NEUpanning mentioned this pull request Sep 27, 2024

Velox doesn't support legacy date format behavior in Spark SQL #10354

Open

17 tasks

Add helper function to return the number of days since epoch for a week-of-month date #10604

Add helper function to return the number of days since epoch for a week-of-month date #10604

Conversation

NEUpanning commented Jul 30, 2024 • edited Loading

netlify bot commented Jul 30, 2024 • edited Loading

✅ Deploy Preview for meta-velox ready!

mbasmanova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NEUpanning commented Jul 30, 2024

rui-mo left a comment

Choose a reason for hiding this comment

rui-mo Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NEUpanning commented Aug 15, 2024

rui-mo left a comment

Choose a reason for hiding this comment

NEUpanning commented Aug 23, 2024

rui-mo left a comment

Choose a reason for hiding this comment

NEUpanning commented Aug 26, 2024

rui-mo commented Aug 27, 2024

mbasmanova left a comment

Choose a reason for hiding this comment

mbasmanova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NEUpanning Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NEUpanning commented Aug 30, 2024

mbasmanova commented Aug 30, 2024

NEUpanning commented Aug 30, 2024

NEUpanning commented Jul 30, 2024 •

edited

Loading

netlify bot commented Jul 30, 2024 •

edited

Loading

rui-mo Jul 30, 2024 •

edited

Loading

NEUpanning Sep 3, 2024 •

edited

Loading