Return null for invalid datetime format when legacy date formatter is used #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
17 tasks
|
@rui-mo Could you help to review this PR please? Thanks. |
rui-mo
reviewed
Oct 12, 2024
NEUpanning
force-pushed
the
invalid_format_return_null
branch
from
72c3c72 to
8ee67ed
Compare
|
@rui-mo Just a gentle ping. |
rui-mo
reviewed
Oct 23, 2024
rui-mo
reviewed
Oct 28, 2024
rui-mo
reviewed
Oct 29, 2024
rui-mo
reviewed
Oct 29, 2024
rui-mo
changed the title
rui-mo
reviewed
Oct 29, 2024
@rui-mo Affected functions include 'unix_timestamp', 'from_unixtime' and 'get_timestamp' . 'unix_timestamp' and 'from_unixtime' in skipFunctions list can't run the expression fuzzer test. 'get_timestamp' passed the expression fuzzer test. Here is command and part of logs: velox/expression/fuzzer/spark_expression_fuzzer_test --duration_sec=60 --logtostderr=1 --only=get_timestamp --minloglevel=0==============================> Started iteration 19076 (seed: 1031779865) I20241029 16:32:45.621546 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",78'lJ0.z>8a8@2c)ptpF[R!IbwOruJTh|@&&|@ILLP19oQN?gytxKt.ID%a$A3e Done with iteration 19076 I20241029 16:32:45.625085 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19077 (seed: 1809594366) I20241029 16:32:45.625448 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp('z7\"QDf")'68Y5z*,"c0") I20241029 16:32:45.625491 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.627204 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.627249 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19077 I20241029 16:32:45.627334 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19078 (seed: 3720383521) I20241029 16:32:45.628737 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(kLL_.D'B^@#eKx5&bJzISy_yB3:jWt=dL;31O9GL3+.qrEE Done with iteration 19078 I20241029 16:32:45.630780 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19079 (seed: 626747346) I20241029 16:32:45.632347 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,"c0") I20241029 16:32:45.632382 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.632833 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.633752 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.634090 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.634151 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.634217 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19079 I20241029 16:32:45.634344 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19080 (seed: 1965053819) I20241029 16:32:45.637182 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(*vP=57xqdi{72l=as2h$J8bu3LgCNF{sw6)zX5$Ku]N)k6qP#S;|EClks.7yJp$+*=t?.+k2x~"iGPX0y?m,"c0") I20241029 16:32:45.637308 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.640367 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.640429 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19080 I20241029 16:32:45.640516 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19081 (seed: 4270023287) I20241029 16:32:45.641335 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(,CR/GcGN8{h-&JeqHC:y~<5`]XZn[0od!X=yuQC|v=kKh'BrP314koeFKY:>jT4]bgCx,u*!6P3qlaDA]&rxHZ]UEC'+}#Usg)JDA4"b<_B#tZR~*nV(=R*s.d~]) I20241029 16:32:45.641387 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.644065 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.644116 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19081 I20241029 16:32:45.644171 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19082 (seed: 1215848348) I20241029 16:32:45.644985 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(R"m>Ebyiml,~m@.,z*9Lh[`pG) I20241029 16:32:45.645022 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.647151 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.647209 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19082 I20241029 16:32:45.647269 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19083 (seed: 2510698031) I20241029 16:32:45.647778 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(vW|%&pped7OViw,"U@sw\fwEwA@dT2LPVuxC{0A!h Done with iteration 19083 I20241029 16:32:45.649554 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19084 (seed: 1695805399) I20241029 16:32:45.650611 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",j]AK) I20241029 16:32:45.650647 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.652163 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.652210 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19084 I20241029 16:32:45.652302 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19085 (seed: 2834880967) I20241029 16:32:45.653800 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,z`7A:%^;kjf45mVUkMA%\nOK"30N{ZeZ[#) I20241029 16:32:45.653872 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.654665 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.656066 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.656412 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.656451 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.656493 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19085 I20241029 16:32:45.656540 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19086 (seed: 136730743) I20241029 16:32:45.657359 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(qc[9w.gx=d@1Tcz$zjgg#IA:^{A,~t~`*YK-SOQ&@_)<0XjJ(*-QN|O~,}GVR}^3Bb={SW6kso0>ds_baVmqpHe4A0d?jGeov&Q).z`D4q"UUw) I20241029 16:32:45.657385 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.658875 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.658910 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19086 I20241029 16:32:45.658954 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19087 (seed: 2261632436) I20241029 16:32:45.659657 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,L%]hVVrd*qowq9$YKe>!=~6iMYDY-!yu,iH_Os}L*o2K`0A) I20241029 16:32:45.659685 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.660061 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.660816 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.661180 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.661218 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.661262 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19087 I20241029 16:32:45.661309 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19088 (seed: 309579018) I20241029 16:32:45.662600 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp((}B5)y({NfZJ7^sa8r~)KTvwrh Done with iteration 19088 I20241029 16:32:45.664245 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19089 (seed: 1553440110) I20241029 16:32:45.664906 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(GX"*UZs7>."!(dt"l]N#-^Vu~'\:@z)wyEPG5[~o,FUUqn`G~GdQ:)n+bR'L;65(ypFD*4uiLz~K'P^ks;mUcbhvuT-4JtU`Q%:!CmFHr~-I( Done with iteration 19089 I20241029 16:32:45.666532 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19090 (seed: 503373242) I20241029 16:32:45.667789 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",XrRBEO!>nQ6[g>U$4/1^:4D'oO4[~Ip4$"_k-<3Gt]\nLt~lNh9t,|EwLEy=lgd)u:-{RVoP*zi`KlQz)) I20241029 16:32:45.667821 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.668229 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.668852 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.669170 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.669210 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.669250 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19090 I20241029 16:32:45.669298 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19091 (seed: 3407390293) I20241029 16:32:45.670892 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(24h?bx0]NGU}`&gD3Mu~v\%6L19,n>t[i#Zge) I20241029 16:32:45.670936 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.673081 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.673122 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19091 I20241029 16:32:45.673167 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19092 (seed: 2812302595) I20241029 16:32:45.673460 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,82qV=t3\YtadojA)<23_evPpgu4e.c;buf;flbVL"MVN4LwXZ[OU[3>9Z_Y!;!;d$) I20241029 16:32:45.673485 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.673902 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.674592 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.675017 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.675067 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.675169 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19092 I20241029 16:32:45.675230 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19093 (seed: 303039075) I20241029 16:32:45.676962 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(YsjmbywP=(C6;Lf:C-HqWy`#]0Bkc/KcNq7s'/mDs`\F2EhCmky,5rcv9M$k`'OndbklO*eb,E~;p1~%NZ,k<) I20241029 16:32:45.676996 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.678740 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.678779 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19093 I20241029 16:32:45.678825 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19094 (seed: 869123364) I20241029 16:32:45.680109 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",Eh-KTA0Ql@6S&2[qmX(q|Y1X^Q\j*=g"!f~a'-:vF|R&xXUIcy{yd9!!O1lg0r&\u@\_"sF#S`nGCb->P) I20241029 16:32:45.680141 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.681635 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.681668 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19094 I20241029 16:32:45.681725 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19095 (seed: 2435226317) I20241029 16:32:45.682811 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(g~48,null) I20241029 16:32:45.682837 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.683233 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.683898 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.684199 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.684238 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.684278 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19095 I20241029 16:32:45.684324 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19096 (seed: 3290345953) I20241029 16:32:45.685771 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(nS9C|U].;hdb+<62Hd+E9t>5Oz+bpQl_}/!bW?pykz\^B,yq) I20241029 16:32:45.685803 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.687718 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.687760 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19096 I20241029 16:32:45.687808 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19097 (seed: 4006506727) I20241029 16:32:45.688172 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(YFVR0=>PpGLe1ZT$pSmjem/:Xz?]~lu;Brrs!eI"1tkBp,!:r1.&F`)!1o4^)-:La!!1$w$,!3Sc_%S8)ya7nLk(=O-H8%`*|&6P@!QwJ}pYxzRnnulXG77h^ATQ*JOBn[M;~gJXV/o?1==]WKwx3) I20241029 16:32:45.688206 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.689905 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.689949 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19097 I20241029 16:32:45.689996 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19098 (seed: 1014787095) I20241029 16:32:45.691339 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",J}QCi&vn)0JjbMoCBg*Fh*x,^&#m_G%gv Done with iteration 19098 I20241029 16:32:45.692953 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19099 (seed: 3477125408) I20241029 16:32:45.694034 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",null) I20241029 16:32:45.694064 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.694617 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.695423 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.695735 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.695776 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.695816 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19099 I20241029 16:32:45.695874 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19100 (seed: 280844952) I20241029 16:32:45.696943 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",+NB4_(OE-G6d8i#}7?9i4?&ae@dx$}|s+g+x{7atgRi:vrerZp}]&M*SQ(H6K"?`a)K~1:Yb3?Z0#[) I20241029 16:32:45.696974 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.698433 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.698468 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19100 I20241029 16:32:45.698515 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19101 (seed: 2336290843) I20241029 16:32:45.699571 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",m*MK}L_xQj.uR]CouA_9[dQH3Ddo,rsIr0) I20241029 16:32:45.699599 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.700883 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.700914 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19101 I20241029 16:32:45.700963 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19102 (seed: 3977173519) I20241029 16:32:45.702294 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",CJbi%/zk[)ZYce@'&l^/T6eErWzlORa!gzC7|B7AcU]U0G>vB,Bh~%Vc&l/J?}JK) I20241029 16:32:45.702330 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.704034 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.704092 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19102 I20241029 16:32:45.704185 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19103 (seed: 2161276535) I20241029 16:32:45.705765 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",KSkhtIkQv4&.@l1kx0fF6tg(pA6+8douk;F$:|) I20241029 16:32:45.705811 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.707715 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.707787 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19103 I20241029 16:32:45.707878 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19104 (seed: 1885038908) I20241029 16:32:45.709318 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",null) I20241029 16:32:45.709357 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.709956 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.710927 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.711341 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.711407 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.711510 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19104 I20241029 16:32:45.711580 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19105 (seed: 1422261845) I20241029 16:32:45.713745 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,"c0") I20241029 16:32:45.713788 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.714247 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.714915 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.715258 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.715301 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.715344 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19105 I20241029 16:32:45.715394 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19106 (seed: 3315319846) I20241029 16:32:45.716647 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(m\8pC2,4\NFh-mG`+$)1=&a+6QH0hmMEV#OxAIAwK@{4eTr|EM'B;nsf^{8t-uKiXE8c;D-=|vcbbvdNZm7,,RxZmSl!q?l<[$,"c0") I20241029 16:32:45.716678 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.718443 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.718479 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19106 I20241029 16:32:45.718536 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19107 (seed: 1139954492) I20241029 16:32:45.720328 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(:}fF^8|^ZY[UZI|c5H@hwDlox%&/$+h[9Hj}A|NBwKY$FnERDog@@l:zeF}O+Gn86^qpRUh=!y_uXAmf2,m:f0sG\aEt#]J.{71Yg&h0)wCzA88J1*54|r2:xc~!4br8v6` Done with iteration 19107 I20241029 16:32:45.722015 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19108 (seed: 3153479635) I20241029 16:32:45.723075 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0","~YW=Y%&R!#/h)mjeeMHf2s#Je\RQJr>M)9[l|G5VuwD\) I20241029 16:32:45.723107 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.724627 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.724663 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19108 I20241029 16:32:45.724715 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19109 (seed: 503518704) I20241029 16:32:45.725103 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(_Wr:"~?6_1z[^_N?}3bp`5LCnA?OIoCI,o[H4!6K}.Hreud&tabhqTN]([mc4joR.Z) I20241029 16:32:45.725132 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.726435 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.726465 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19109 I20241029 16:32:45.726505 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19110 (seed: 2867061681) I20241029 16:32:45.727648 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",null) I20241029 16:32:45.727676 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.728127 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.728884 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.729183 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.729223 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.729260 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19110 I20241029 16:32:45.729313 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19111 (seed: 3431342043) I20241029 16:32:45.730960 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(null,"c0") I20241029 16:32:45.730989 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.731647 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.732462 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.732789 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.732831 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.732873 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19111 I20241029 16:32:45.732932 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19112 (seed: 4032658592) I20241029 16:32:45.734045 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",\;0_p3%]'z7ayP9yvsJ]Y{~BcG43l.[*'M%zqh9gsNbR;Ne}?b.5R&De-ZoI\(4nkSqU_m!e~3%Z7&) I20241029 16:32:45.734081 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.735477 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.735512 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19112 I20241029 16:32:45.735563 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19113 (seed: 3840540695) I20241029 16:32:45.737707 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(WNa|KY0*7%\5^pfd[,"c0") I20241029 16:32:45.737747 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.739435 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.739472 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19113 I20241029 16:32:45.739531 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19114 (seed: 1066006458) I20241029 16:32:45.740729 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(I6e10,Cf>TL7hC3"2YpAw42)Kj'\:SY3/wQ5X7O2`@%"zL_'N&c_vG656pn+8+A/bzwmzbQk5{M^p.m]gfY`9#JcI>b/s]{$+IG],OBPc) I20241029 16:32:45.740756 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.742110 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.742144 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19114 I20241029 16:32:45.742187 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19115 (seed: 1920196218) I20241029 16:32:45.743316 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0",null) I20241029 16:32:45.743345 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.743829 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.744632 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.744944 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.744984 3642830 FuzzerToolkit.cpp:137] Two vectors match. I20241029 16:32:45.745023 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19115 I20241029 16:32:45.745079 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19116 (seed: 2893539737) I20241029 16:32:45.747043 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp("c0","c1") I20241029 16:32:45.747079 3642830 ExpressionVerifier.cpp:80] Executing expression 1 : "row_number" I20241029 16:32:45.748538 3642830 FuzzerToolkit.cpp:103] Exceptions match. I20241029 16:32:45.748571 3642830 ExpressionFuzzerVerifier.cpp:408] ==============================> Done with iteration 19116 I20241029 16:32:45.748628 3642830 ExpressionFuzzerVerifier.cpp:347] ==============================> Started iteration 19117 (seed: 1986025404) I20241029 16:32:45.750571 3642830 ExpressionVerifier.cpp:80] Executing expression 0 : get_timestamp(Process finished with exit code 0 |
rui-mo
approved these changes
Oct 30, 2024
|
@pedroerp Could you help to review this PR please? Thanks. |
rui-mo
added
the
ready-to-merge
mbasmanova
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@NEUpanning Does this change the behavior of some Presto or Spark functions? If so, please, update the docs.
@mbasmanova Yes, this PR changes the behavior of the functions |
mbasmanova
approved these changes
Nov 5, 2024
|
@NEUpanning CI is red. Would you take a look? |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@NEUpanning Would you rebase and fix a lint? 
|
NEUpanning
force-pushed
the
invalid_format_return_null
branch
from
9f46a11 to
1119cbb
Compare
|
@mbasmanova I've rebased to the main branch and made the 'initializeFormmater' function inline. |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 64661a3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Spark functions 'unix_timestamp', 'from_unixtime' and 'get_timestamp',
returns null for invalid datetime format when legacy date formatter is used.
Relating to #10354.