Allow ExpressionRunnerTest to run with PrestoQueryRunner #11254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64359866 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
approved these changes
Oct 16, 2024
xiaoxmeng
approved these changes
Oct 16, 2024
kagamiori
force-pushed
the
export-D64359866
branch
from
0561a41 to
59e17fa
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 24, 2024
…ubator#11254) Summary: This is for facebookincubator#10308. Reviewed By: kevinwilfong, xiaoxmeng Differential Revision: D64359866
|
This pull request was exported from Phabricator. Differential Revision: D64359866 |
…ubator#11254) Summary: This is for facebookincubator#10308. Reviewed By: kevinwilfong, xiaoxmeng Differential Revision: D64359866
kagamiori
force-pushed
the
export-D64359866
branch
from
59e17fa to
52c02b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64359866 |
|
This pull request has been merged in 9784f22. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ubator#11254) Summary: Pull Request resolved: facebookincubator#11254 This is for facebookincubator#10308. Reviewed By: kevinwilfong, xiaoxmeng Differential Revision: D64359866 fbshipit-source-id: 031aa4de40b2969901c605d97d23506fff5f0490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is for #10308.
Differential Revision: D64359866