Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single parameter (array<array<T>>) support for array_intersect #11305

Closed
wants to merge 1 commit into from
Closed

Add single parameter (array<array<T>>) support for array_intersect #11305

wants to merge 1 commit into from

Conversation

kewang1024
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit bf0618a
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6719fcfdf695e80008735d23

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 17b9288 to 908c29c Compare October 21, 2024 07:32
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 908c29c to 4b936b8 Compare October 22, 2024 09:07
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 4b936b8 to 5ef71dd Compare October 22, 2024 09:08
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 changed the title Add support of array<array<T>> for array_intersect where T is primitive type Add single parameter (array<array<T>>) support for array_intersect Oct 22, 2024
kevinwilfong
kevinwilfong approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kevinwilfong kevinwilfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ke!

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 5ef71dd to 10b8fc4 Compare October 22, 2024 17:06
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 10b8fc4 to eec04a4 Compare October 22, 2024 17:08
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from eec04a4 to a5908de Compare October 24, 2024 00:17
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from a5908de to 4d46697 Compare October 24, 2024 07:02
@kewang1024 kewang1024 force-pushed the array_intersect_arrayofArray branch from 4d46697 to bf0618a Compare October 24, 2024 07:53
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 merged this pull request in 8d77beb.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 8d77bebb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@kewang1024 @athmaja-n
Add single parameter (array<array<T>>) support for array_intersect (f…
536ffe2 
…acebookincubator#11305)

Summary: Pull Request resolved: facebookincubator#11305

Reviewed By: kevinwilfong

Differential Revision: D64698174

Pulled By: kewang1024

fbshipit-source-id: 6a9cefb24565c004fad956d8ba265172723fb29c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwilfong kevinwilfong kevinwilfong approved these changes

@amitkdutta amitkdutta Awaiting requested review from amitkdutta

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kewang1024 @facebook-github-bot @kevinwilfong