Support unary and binary arithmetic operators in expression fuzzer against Presto #11313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64711683 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 21, 2024
…to (facebookincubator#11313) Summary: Extend PrestoQueryRunner to translate Velox function names to the corresponding binary operators supported in Presto SQL. This is needed for testing binary arithmetic operators in expression fuzzer wtih PQR. Reviewed By: kevinwilfong Differential Revision: D64711683
kagamiori
force-pushed
the
export-D64711683
branch
from
5146118 to
183c8a1
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 21, 2024
…to (facebookincubator#11313) Summary: Extend PrestoQueryRunner to translate Velox function names to the corresponding binary operators supported in Presto SQL. This is needed for testing binary arithmetic operators in expression fuzzer wtih PQR. Reviewed By: kevinwilfong Differential Revision: D64711683
kagamiori
force-pushed
the
export-D64711683
branch
from
183c8a1 to
5b04cec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64711683 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64711683 |
kagamiori
changed the title
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 21, 2024
…ainst Presto (facebookincubator#11313) Summary: Extend PrestoQueryRunner to translate Velox function names to the corresponding unary and binary operators supported in Presto SQL. This is needed for testing unary and binary arithmetic operators in expression fuzzer wtih PQR. Reviewed By: kevinwilfong Differential Revision: D64711683
kagamiori
force-pushed
the
export-D64711683
branch
from
5b04cec to
3395222
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64711683 |
…ainst Presto (facebookincubator#11313) Summary: Extend PrestoQueryRunner to translate Velox function names to the corresponding unary and binary operators supported in Presto SQL. This is needed for testing unary and binary arithmetic operators in expression fuzzer wtih PQR. Reviewed By: kevinwilfong Differential Revision: D64711683
kagamiori
force-pushed
the
export-D64711683
branch
from
3395222 to
5823fb7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64711683 |
|
This pull request has been merged in ca9581c. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ainst Presto (facebookincubator#11313) Summary: Pull Request resolved: facebookincubator#11313 Extend PrestoQueryRunner to translate Velox function names to the corresponding unary and binary operators supported in Presto SQL. This is needed for testing unary and binary arithmetic operators in expression fuzzer wtih PQR. Reviewed By: kevinwilfong Differential Revision: D64711683 fbshipit-source-id: 0c1ddb945697d45d2a5c5de3cff4d5d400f6acd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Extend PrestoQueryRunner to translate Velox function names to the corresponding unary and
binary operators supported in Presto SQL. This is needed for testing unary and binary arithmetic
operators in expression fuzzer wtih PQR.
Differential Revision: D64711683