Add FilterProjectReplayer #11351
Closed
Add FilterProjectReplayer #11351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanmeng
requested review from
xiaoxmeng
and removed request for
majetideepak and
assignUser
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
duanmeng
force-pushed
the
trace_fp
branch
8 times, most recently
from
bbcfc21 to
03c8edf
Compare
xiaoxmeng
reviewed
Oct 30, 2024
| VELOX_CHECK( | ||
| !isFilterProject(filterNode), | ||
| "If the target node is aFilterNode, it must be a standalone " | ||
| "FilterNode, without a ProjectNode as its parent."); |
There was a problem hiding this comment.
without a ProjectNode as its consumer ?
not sure if it should call parent or consumer. It is basically the downstream node of filter node? thanks!
There was a problem hiding this comment.
Just use "If the target node is a FilterNode, it must be a standalone FilterNode"?
duanmeng
force-pushed
the
trace_fp
branch
3 times, most recently
from
c577fa0 to
91ae9d8
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in ad27145. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FilterProjectReplayer. For the plan fragment involving
FilterNode->ProjectNode, users should use the ProjectNode
ID for tracing. This is because the planner will combine these
two operators into a single FilterProject operator. During replay,
the ProjectNode ID will locate the trace data directory.
Part of #9668