Add Row ID column reading support #11363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
Yuhta
force-pushed
the
export-D65028172
branch
from
b2cbd60 to
aba7e64
Compare
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 28, 2024
Summary: Pull Request resolved: facebookincubator#11363 Create framework in selective readers for generating row number field and composite with other constant fields. Then use this framework to add support for Row ID column. We move the row number generation logic into column reader during this process, so that we could filter them if needed in the future. Differential Revision: D65028172
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 28, 2024
Summary: Pull Request resolved: facebookincubator#11363 Create framework in selective readers for generating row number field and composite with other constant fields. Then use this framework to add support for Row ID column. We move the row number generation logic into column reader during this process, so that we could filter them if needed in the future. Differential Revision: D65028172
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
Yuhta
force-pushed
the
export-D65028172
branch
from
aba7e64 to
655a24a
Compare
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 28, 2024
Summary: Pull Request resolved: facebookincubator#11363 Create framework in selective readers for generating row number field and composite with other constant fields. Then use this framework to add support for Row ID column. We move the row number generation logic into column reader during this process, so that we could filter them if needed in the future. Differential Revision: D65028172
Yuhta
force-pushed
the
export-D65028172
branch
from
655a24a to
cc7143e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Oct 28, 2024
Summary: Pull Request resolved: facebookincubator#11363 Create framework in selective readers for generating row number field and composite with other constant fields. Then use this framework to add support for Row ID column. We move the row number generation logic into column reader during this process, so that we could filter them if needed in the future. Differential Revision: D65028172
Yuhta
force-pushed
the
export-D65028172
branch
from
cc7143e to
923f711
Compare
Summary: Pull Request resolved: facebookincubator#11363 Create framework in selective readers for generating row number field and composite with other constant fields. Then use this framework to add support for Row ID column. We move the row number generation logic into column reader during this process, so that we could filter them if needed in the future. Differential Revision: D65028172
|
This pull request was exported from Phabricator. Differential Revision: D65028172 |
Yuhta
force-pushed
the
export-D65028172
branch
from
923f711 to
b45c25c
Compare
|
This pull request has been merged in 2e0acb7. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create framework in selective readers for generating row number field
and composite with other constant fields. Then use this framework to add
support for Row ID column. We move the row number generation logic into column
reader during this process, so that we could filter them if needed in the
future.
Differential Revision: D65028172