Support global arbitration without spilling enabled in arbitrator #11381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
reviewed
Oct 30, 2024
tanjialiang
force-pushed
the
global_arb_no_spill
branch
from
2d43445 to
4f7b2cf
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Oct 30, 2024
| (getCurrentTimeMs() - startTimeMs) < maxArbitrationTimeMs_ / 2 && | ||
| (reclaimByAbort || (allParticipantsReclaimed && reclaimedBytes == 0)); | ||
| if (!reclaimByAbort) { | ||
| shouldReclaimByAbort = globalArbitrationWithoutSpill_ || |
There was a problem hiding this comment.
Maybe add a utility
bool reclaimByAbort = reclaimByAbort(/*hasReclaimedByAbort=*/reclaimByAbort, arbitrationRunTime, allParticipantsReclaimed, /*lastReclaimedBytes=*/reclaimedBytes);
4f7b2cf to
54f8975
Compare
tanjialiang
force-pushed
the
global_arb_no_spill
branch
from
54f8975 to
c98c5a1
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang merged this pull request in 2090d78. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature that allows shared arbitrator's global arbitration to skip spilling, only do abort.