Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPADDRESS error message #11448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohsaka
Copy link
Contributor

@mohsaka mohsaka commented Nov 6, 2024

We should be returning the input type not the result type, which is IPADDRESS

Split from:
#11309

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 5fddd00
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/672ab561371bf900087a9d88

Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mohsaka

@aditi-pandit aditi-pandit requested a review from Yuhta November 6, 2024 15:41
Copy link

stale bot commented Feb 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants