New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ip_prefix function [4/n] #11514

Open

yuandagits wants to merge 2 commits into facebookincubator:main from yuandagits:export-D65802211

Contributor

yuandagits commented Nov 12, 2024 •

edited

Loading

Summary:
Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from #11407

Differential Revision: D65802211

facebook-github-bot added the CLA Signed label

netlify bot commented Nov 12, 2024 •

edited

Loading

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`77de4ac`
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/675bad10e1a3be0009c97d14

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

facebook-github-bot added the fb-exported label

yuandagits marked this pull request as draft

November 12, 2024 18:59

yuandagits force-pushed the export-D65802211 branch from 1521c1c to 29dfe37 Compare

November 12, 2024 19:28

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

29dfe37

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Differential Revision: D65802211

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

da9fde7

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 29dfe37 to da9fde7 Compare

November 12, 2024 19:34

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

f6f6f32

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from da9fde7 to f6f6f32 Compare

November 12, 2024 19:53

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

fc2851b

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

524cfba

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from f6f6f32 to 524cfba Compare

November 12, 2024 19:58

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

28fa3b3

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 524cfba to 28fa3b3 Compare

November 12, 2024 20:05

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 28fa3b3 to 0ea750c Compare

November 12, 2024 20:08

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

d60de75

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 0ea750c to d60de75 Compare

November 12, 2024 20:21

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits marked this pull request as ready for review

November 12, 2024 20:57

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [3/n] (facebookincubator#11514)

c2d828c

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

afaa059

Summary:

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. 

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits changed the title ~~Add ip_prefix function [3/n]~~ feat: Add ip_prefix function [3/n]

Contributor

facebook-github-bot commented Dec 10, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

1 similar comment

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

49f1b48

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from d6f5670 to 49f1b48 Compare

December 11, 2024 15:56

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

60f34ea

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 49f1b48 to 60f34ea Compare

December 11, 2024 16:18

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

1 similar comment

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

e38f029

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 60f34ea to e38f029 Compare

December 11, 2024 16:31

spershin approved these changes

View reviewed changes

Contributor

spershin left a comment

Seems fuzzer failure is due to a bug.

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

3e68c74

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from e38f029 to 3e68c74 Compare

December 12, 2024 03:53

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

e5e879b

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 3e68c74 to e5e879b Compare

December 12, 2024 04:27

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

997d80d

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from e5e879b to 997d80d Compare

December 12, 2024 05:31

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

1 similar comment

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

8f4c540

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 997d80d to 8f4c540 Compare

December 12, 2024 11:32


          Generated from a GitHub Pull Request. Run 'jf sync' on this diff to l…

500a542

…oad the correct commit data.

Differential Revision: D67159266

yuandagits force-pushed the export-D65802211 branch from 8f4c540 to 3d27e3a Compare

December 12, 2024 22:21

yuandagits added a commit to yuandagits/velox that referenced this pull request


          Add ip_prefix function [4/n] (facebookincubator#11514)

3d27e3a

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211


          Add ip_prefix function [4/n] (facebookincubator#11514)

77de4ac

Summary:
Pull Request resolved: facebookincubator#11514

Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.

Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.

We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.

Split from facebookincubator#11407

Reviewed By: spershin

Differential Revision: D65802211

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D65802211

yuandagits force-pushed the export-D65802211 branch from 3d27e3a to 77de4ac Compare

December 13, 2024 03:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported