feat: Support comparison for ipprefix [3/n] #11546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 15, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 15, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
90db886 to
a24558c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
changed the title
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 2, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
a24558c to
30d72b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
force-pushed
the
export-D65521072
branch
from
30d72b2 to
9d883a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
force-pushed
the
export-D65521072
branch
from
9d883a8 to
d2d01f5
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 5, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
force-pushed
the
export-D65521072
branch
from
d2d01f5 to
4bb987a
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
4bb987a to
1517279
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
1517279 to
59ec40d
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
Yuhta
reviewed
Dec 6, 2024
| auto left = makeArrayOfRowVector( | ||
| IPPREFIX(), | ||
| {{ipprefix("2001:0db8:0000:0000:0000:ff00:0042:8329/128")}, | ||
| {ipprefix("1.2.3.4/32")}, |
There was a problem hiding this comment.
Presto has this:
> select ipprefix '1.2.3.4/24' = ipprefix '1.2.3.5/24';
_col0
-------
true
(1 row)
Can we make sure Velox behaves the same?
There was a problem hiding this comment.
updated with the new test case, thanks Jimmy!
There was a problem hiding this comment.
Discussed offline, we are masking the extra bits to zeros like Java did when we creating new ipprefix, so we don't need this test case (it's invalid input).
yuandagits
force-pushed
the
export-D65521072
branch
from
59ec40d to
0a75675
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 6, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
force-pushed
the
export-D65521072
branch
from
0a75675 to
8726e15
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 8, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 8, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
8726e15 to
49418ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 8, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
49418ed to
ecf18b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 9, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
ecf18b1 to
e89edac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
Yuhta
approved these changes
Dec 9, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Reviewed By: Yuhta Differential Revision: D65521072
yuandagits
force-pushed
the
export-D65521072
branch
from
e89edac to
c210b19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65521072 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 9, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Reviewed By: Yuhta Differential Revision: D65521072
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 10, 2024
Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Reviewed By: Yuhta Differential Revision: D65521072
|
This pull request has been merged in c12207a. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11546 We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>. Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free. Reviewed By: Yuhta Differential Revision: D65521072 fbshipit-source-id: 3e21e2fa4ff5d1306dc5dde601168bb659e54303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>.
Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free.
Differential Revision: D65521072