fix(joins): Strengthen nullptr check for null aware hash joins with filters #11620
+92
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Differential Revision: D66333546
kagamiori
reviewed
Nov 22, 2024
DanielHunte
force-pushed
the
export-D66333546
branch
from
50fac30 to
c4d9bba
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 22, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Differential Revision: D66333546
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
Yuhta
approved these changes
Nov 22, 2024
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
c4d9bba to
535477d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
535477d to
7b980de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
7b980de to
3494ac9
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 26, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
3494ac9 to
201f88b
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 26, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 26, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
201f88b to
b6b675d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 26, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 6, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
3be06aa to
edbe4d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 6, 2024
…ilters (facebookincubator#11620) Summary: Pull Request resolved: facebookincubator#11620 The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
edbe4d6 to
9a5973d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
9a5973d to
56dcc39
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
56dcc39 to
1b71600
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
added 3 commits
December 13, 2024 17:16
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
force-pushed
the
export-D66333546
branch
from
1b71600 to
aedecdc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66333546 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy.
Differential Revision: D66333546