feat: Add Global Config in place of gflags #11745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Dec 4, 2024
majetideepak
force-pushed
the
remove-gflags
branch
2 times, most recently
from
7f84965 to
47a3a23
Compare
|
@Yuhta can you take another look? I modified it according to your suggestion. |
majetideepak
force-pushed
the
remove-gflags
branch
2 times, most recently
from
046911b to
888dd49
Compare
|
@majetideepak Yes it looks good now. We also need a translation function from gflags to this new settings, so that people can do the migration seamlessly. |
|
I guess we can create the translation function in a separate library and map the gflag to this global config. I will add this function. |
majetideepak
force-pushed
the
remove-gflags
branch
2 times, most recently
from
d961d89 to
7ef8932
Compare
|
@Yuhta Can you take another look? Thanks. |
majetideepak
force-pushed
the
remove-gflags
branch
from
7ef8932 to
70ef709
Compare
Yuhta
reviewed
Dec 6, 2024
majetideepak
changed the title
majetideepak
force-pushed
the
remove-gflags
branch
3 times, most recently
from
a4bdf43 to
41690d4
Compare
majetideepak
force-pushed
the
remove-gflags
branch
from
ce3cc4f to
3619ba0
Compare
majetideepak
force-pushed
the
remove-gflags
branch
from
3619ba0 to
4bc9d63
Compare
|
@Yuhta This is ready for another pass. |
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of gflags from velox_memory and velox_exception