fix(timestamp): toMicros() should work for all timestamps fitting in bigint #11774
+17
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
boneanxs
force-pushed
the
toMicro_overflow
branch
from
966f563 to
09a1ee4
Compare
boneanxs
changed the title
boneanxs
force-pushed
the
toMicro_overflow
branch
from
86b1e46 to
eb494af
Compare
jinchengchenghh
approved these changes
Dec 12, 2024
rui-mo
changed the title
rui-mo
changed the title
rui-mo
changed the title
rui-mo
approved these changes
Dec 12, 2024
velox/type/Timestamp.h
Outdated
|
|
||
| // If the final result does not fit in int64_t we throw. | ||
| __int128_t result = | ||
| (__int128_t)seconds_ * 1'000'000 + (int64_t)(nanos_ / 1'000); |
There was a problem hiding this comment.
nit: use static_cast to avoid C-style casts. See 28c319e.
|
@laithsakka @kagamiori Would you please help review this fix similar to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #7506, toMicros() throws because the computation overflows when multiplying
negative number then add positive number. In this case the final result still
fits in int64_t. This PR fixes this issue by using int128_t to make sure the
computation does not overflows.