refactor: Use KeepAlive instead of Executor*" #11785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D66911053 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
pedroerp
added a commit
to pedroerp/nimble
that referenced
this pull request
Dec 7, 2024
Summary: X-link: facebookincubator/velox#11785 Original PR got reverted as it conflicted with a different internal change. Resubmitting it. Original PR: facebookincubator/velox#11732 Differential Revision: D66911053
Yuhta
approved these changes
Dec 7, 2024
xiaoxmeng
approved these changes
Dec 7, 2024
pedroerp
added a commit
to pedroerp/nimble
that referenced
this pull request
Dec 10, 2024
Summary: X-link: facebookincubator/velox#11785 Original PR got reverted as it conflicted with a different internal change. Resubmitting it. Original PR: facebookincubator/velox#11732 Reviewed By: xiaoxmeng Differential Revision: D66911053
Summary: X-link: facebookincubator/nimble#112 Original PR got reverted as it conflicted with a different internal change. Resubmitting it. Original PR: facebookincubator#11732 Reviewed By: xiaoxmeng Differential Revision: D66911053
pedroerp
force-pushed
the
export-D66911053
branch
from
7c57cb7 to
6c28f9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66911053 |
facebook-github-bot
pushed a commit
to facebookincubator/nimble
that referenced
this pull request
Dec 10, 2024
Summary: Pull Request resolved: #112 X-link: facebookincubator/velox#11785 Original PR got reverted as it conflicted with a different internal change. Resubmitting it. Original PR: facebookincubator/velox#11732 Reviewed By: xiaoxmeng Differential Revision: D66911053 fbshipit-source-id: fefb086276f3fd442760774d08ac31de9063ab60
|
This pull request has been merged in 47a3ea6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original PR got reverted as it conflicted with a different internal change.
Resubmitting it.
Original PR: #11732
Differential Revision: D66911053