feat(fuzzer): Support multiple joins in the join node "toSql" methods for reference query runners #11801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
e573440 to
f24cd12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
f24cd12 to
6e9702c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…in Presto QR (facebookincubator#11801) Summary: Currently, the hash join "toSql" method for PrestoQueryRunner only supports a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
6e9702c to
3cbd9e0
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
…for reference query runners (facebookincubator#11801) Summary: Currently, the hash join "toSql" method for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
changed the title
DanielHunte
changed the title
DanielHunte
force-pushed
the
export-D66977480
branch
from
3cbd9e0 to
28f2244
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
28f2244 to
180fe64
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
180fe64 to
731d39f
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
731d39f to
211a0b3
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
211a0b3 to
3befde2
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
force-pushed
the
export-D66977480
branch
from
3befde2 to
1db434c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
force-pushed
the
export-D66977480
branch
from
3a104b1 to
dce89f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
force-pushed
the
export-D66977480
branch
from
dce89f3 to
2c7f823
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 10, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
force-pushed
the
export-D66977480
branch
from
2c7f823 to
de4ba34
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66977480 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 15, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 15, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 15, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 15, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 15, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
kevinwilfong
approved these changes
Jan 16, 2025
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 16, 2025
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Reviewed By: kevinwilfong Differential Revision: D66977480
|
This pull request has been merged in 8519fad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query.
Differential Revision: D66977480