Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support viewfs file system in velox #11811

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Support viewfs file system in velox #11811

wants to merge 2 commits into from
+32 −16

Conversation

JkSelf
Copy link
Collaborator

@JkSelf JkSelf commented Dec 10, 2024 •
edited
Loading

Support Viewfs file system in velox.

@JkSelf JkSelf requested a review from majetideepak as a code owner December 10, 2024 06:29
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b11583b
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/675b9dde272b730008c4fc7d

@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 10, 2024

@majetideepak Can you help to review this PR? Thanks.

majetideepak
majetideepak reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JkSelf can we add some read/write tests? If not, can we add some unit tests for the "viewfs" scheme?

@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 11, 2024

@JkSelf can we add some read/write tests? If not, can we add some unit tests for the "viewfs" scheme?

@majetideepak Thanks for your review. I have fixed the failed unit tests and added the viewfs scheme test. Can you help to review again? Thanks.

majetideepak
majetideepak approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JkSelf

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Dec 11, 2024
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai
Copy link
Contributor

kgpai commented Dec 12, 2024

Hi @JkSelf , Can you confirm/investigate that the fuzzer failure isnt due to your changes ?

@JkSelf JkSelf force-pushed the viewfs-support-velox-upstream branch from 84624a8 to b11583b Compare December 13, 2024 02:37
@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 13, 2024

Hi @JkSelf , Can you confirm/investigate that the fuzzer failure isnt due to your changes ?

@kgpai The failure is not due to this pr. I have rebased and the tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bikramSingh91 bikramSingh91 bikramSingh91 approved these changes

@majetideepak majetideepak majetideepak approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JkSelf @facebook-github-bot @kgpai @majetideepak @bikramSingh91