fix(fuzzer): Fix SQL translation of between() in PrestoQueryRunner #11819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67058882 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
changed the title
yuandagits
approved these changes
Dec 10, 2024
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 10, 2024
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Differential Revision: D67058882
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 10, 2024
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
kagamiori
force-pushed
the
export-D67058882
branch
from
dd128e3 to
4f87618
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67058882 |
yuandagits
pushed a commit
to yuandagits/velox
that referenced
this pull request
Dec 11, 2024
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Differential Revision: D67058882
kagamiori
force-pushed
the
export-D67058882
branch
from
4f87618 to
6fbfff3
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 11, 2024
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
|
This pull request was exported from Phabricator. Differential Revision: D67058882 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 11, 2024
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
kagamiori
force-pushed
the
export-D67058882
branch
from
6fbfff3 to
b2769ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67058882 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 12, 2024
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
yuandagits
pushed a commit
to yuandagits/velox
that referenced
this pull request
Dec 12, 2024
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Differential Revision: D67058882
yuandagits
pushed a commit
to yuandagits/velox
that referenced
this pull request
Dec 12, 2024
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Differential Revision: D67058882
yuandagits
pushed a commit
to yuandagits/velox
that referenced
this pull request
Dec 12, 2024
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Differential Revision: D67058882
|
This pull request has been merged in 1deda17. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…acebookincubator#11819) Summary: Pull Request resolved: facebookincubator#11819 The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882 fbshipit-source-id: 7b417ddf4e7b57aa48a286e9c21ea73abf8fe506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care
of between() when translating an expression to SQL.
Differential Revision: D67058882