fix(fuzzer): Mark IPADDRESS and IPPREFIX types as unsuppported input types in PrestoQueryRunner #11820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67060600 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 11, 2024
…types in PrestoQueryRunner (facebookincubator#11820) Summary: Pull Request resolved: facebookincubator#11820 Mark IPADDRES and IPPREFIX types as unsuppported input types in PrestoQueryRunner because Presto doesn't allow creating HIVE columns of these types and requires constant literals of these types to be valid strings. Differential Revision: D67060600
kagamiori
force-pushed
the
export-D67060600
branch
from
af8f977 to
b4faa23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67060600 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 11, 2024
…types in PrestoQueryRunner (facebookincubator#11820) Summary: Pull Request resolved: facebookincubator#11820 Mark IPADDRES and IPPREFIX types as unsuppported input types in PrestoQueryRunner because Presto doesn't allow creating HIVE columns of these types and requires constant literals of these types to be valid strings. Reviewed By: kevinwilfong Differential Revision: D67060600
kagamiori
force-pushed
the
export-D67060600
branch
from
b4faa23 to
83490ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67060600 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 11, 2024
…types in PrestoQueryRunner (facebookincubator#11820) Summary: Mark IPADDRES and IPPREFIX types as unsuppported input types in PrestoQueryRunner because Presto doesn't allow creating HIVE columns of these types and requires constant literals of these types to be valid strings. Reviewed By: kevinwilfong Differential Revision: D67060600
kagamiori
force-pushed
the
export-D67060600
branch
from
83490ad to
db14d90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67060600 |
…acebookincubator#11819) Summary: The between() function requires a special syntax in SQL. This diff fixes PrestoQueryRunner to take care of between() when translating an expression to SQL. Reviewed By: yuandagits Differential Revision: D67058882
…types in PrestoQueryRunner (facebookincubator#11820) Summary: Mark IPADDRES and IPPREFIX types as unsuppported input types in PrestoQueryRunner because Presto doesn't allow creating HIVE columns of these types and requires constant literals of these types to be valid strings. Reviewed By: kevinwilfong Differential Revision: D67060600
kagamiori
force-pushed
the
export-D67060600
branch
from
db14d90 to
d57f98a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67060600 |
|
This pull request has been merged in a775a6c. |
BryanCutler
added a commit
to BryanCutler/velox
that referenced
this pull request
Dec 14, 2024
…Runner Summary: Mark UUID type as unsupported input type in Presto because Presto doesn't allow creating HIVE columns of this type and requires constant literals of these types to be valid string. This follows a similar fix for IPADDRESS and IPPREFIX from facebookincubator#11820.
BryanCutler
added a commit
to BryanCutler/velox
that referenced
this pull request
Dec 14, 2024
…Runner Summary: Mark UUID type as unsupported input type in Presto because Presto doesn't allow creating HIVE columns of this type and requires constant literals of these types to be valid string. This follows a similar fix for IPADDRESS and IPPREFIX from facebookincubator#11820.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mark IPADDRES and IPPREFIX types as unsuppported input types in PrestoQueryRunner because
Presto doesn't allow creating HIVE columns of these types and requires constant literals of these types
to be valid strings.
Differential Revision: D67060600