feat: Support prefix comparator in spill merge #11824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
jinchengchenghh
force-pushed
the
spill_prefix
branch
from
99750dc to
8eb518d
Compare
xiaoxmeng
reviewed
Dec 13, 2024
There was a problem hiding this comment.
@tanjialiang can you help merge this PR if we see >2x performance improvement on spill merge stage or >10% e2e query execution time with meta internal workload? thanks!
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the prefix buffer when merge the RowVector from files, it will only take effect when the number of normalized key is more than 2, because 1 sort key query may not benefit from prefix buffer because it compares by accessing the RowVector one column value buffer and null buffer.
Use the config
spill_merge_prefix_comparator_enabledto control the behavior, default true.The integration test shows it can accelerate TPCDS Q97 5% when the sort keys are {BIGINT(), BIGINT()}. It should benefit more if there are more sort keys or more spilled files.