refactor: Enable Parquet and Arrow by default #11832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
zuyu
force-pushed
the
parquet-arrow-enable-by-default
branch
from
43dc9d0 to
a99a5fb
Compare
|
Do we really want to remove the entire option to build velox without parquet/arrow? I haven't followed the prior PR if this was discussed. Is it now used in the core of velox? @majetideepak you commented on this in the other PR? |
zuyu
force-pushed
the
parquet-arrow-enable-by-default
branch
from
a99a5fb to
b342ac0
Compare
|
My comment #11698 (comment) was misunderstood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @majetideepak in #11698 (comment).
Enable Parquet by default, which needs Arrow, thus Arrow is also enabled by default.