Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Spark Factorial Function #11844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Spark Factorial Function #11844

wants to merge 1 commit into from

Conversation

ArnavBalyan
Copy link

@ArnavBalyan ArnavBalyan commented Dec 12, 2024 •
edited
Loading

  • Currently Spark Factorial supports factorials till 20 returning bigints.
  • Added similar support so that functions can be offloaded to Velox preventing fallbacks from Gluten side.
  • Using a lookup array since Spark just supports factorial till 20, and calculation would be expensive otherwise.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 2e130cf
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/675b0654542ea20008a1c2b1

@ArnavBalyan ArnavBalyan mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnavBalyan @facebook-github-bot