fix(fuzzer): Fix sanitize(type) in FuzzerUtil for IPPREFIX type #11846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
thank you so much! |
yuandagits
approved these changes
Dec 12, 2024
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kagamiori
force-pushed
the
fix_fuzzer_util_ipprefix_pr
branch
from
c713ab0 to
37694e1
Compare
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanitize(type) method incorrectly converts the IPPrefixType into a RowType, which cause error during expression compilation of a fuzzer run. Since IPPrefixType already has field names, there is no need to sanitize it. This diff makes sanitize(type) skip sanitizing IPPrefixType.