Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fuzz checkpoint/checksum related parameters #11848

Closed
wants to merge 1 commit into from

Conversation

zacw7
Copy link
Contributor

@zacw7 zacw7 commented Dec 13, 2024

Summary: Remove checkpoint/checksum related parameters from fixed values and allow them to be randomized by fuzzer so more scenarios can be covered.

Differential Revision: D67172539

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67172539

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 8b9b72c
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/675cb854dec8ed000813a56a

zacw7 added a commit to zacw7/velox that referenced this pull request Dec 13, 2024
…11848)

Summary:

Remove checkpoint/checksum related parameters from fixed values and allow them to be randomized by fuzzer so more scenarios can be covered.

Differential Revision: D67172539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67172539

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67172539

zacw7 added a commit to zacw7/velox that referenced this pull request Dec 13, 2024
…11848)

Summary:
Pull Request resolved: facebookincubator#11848

Remove checkpoint/checksum related parameters from fixed values and allow them to be randomized by fuzzer so more scenarios can be covered.

Differential Revision: D67172539
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacw7 thanks for the improvement!

velox/exec/fuzzer/CacheFuzzer.cpp Show resolved Hide resolved
zacw7 added a commit to zacw7/velox that referenced this pull request Dec 13, 2024
…11848)

Summary:
Pull Request resolved: facebookincubator#11848

Remove checkpoint/checksum related parameters from fixed values and allow them to be randomized by fuzzer so more scenarios can be covered.

Differential Revision: D67172539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67172539

@zacw7 zacw7 requested a review from xiaoxmeng December 13, 2024 22:26
…11848)

Summary:
Pull Request resolved: facebookincubator#11848

Remove checkpoint/checksum related parameters from fixed values and allow them to be randomized by fuzzer so more scenarios can be covered.

Differential Revision: D67172539
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67172539

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacw7 thanks and please make sure cache fuzzer is green in internal nightly run. thanks!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e27c8f3.

@zacw7 zacw7 deleted the export-D67172539 branch December 14, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants