refactor: Add arg cpuExecutor to ConnectorFactory::newConnector #11861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gggrace14
force-pushed
the
cpuexec
branch
2 times, most recently
from
eee9a8e to
7360e66
Compare
gggrace14
changed the title
gggrace14
requested review from
Yuhta and
xiaoxmeng
and removed request for
majetideepak
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Ah, thank you, @xiaoxmeng , for the prompt review :) |
Add an additional argument, cpuExecutor, to the ConnectorFactory's newConnector interface. Connectors could send async operators to this cpuExecutor to prevent occupying the driver executor.
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@gggrace14 merged this pull request in 22ba7ec. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…bookincubator#11861) Summary: Add an additional argument, cpuExecutor, to the ConnectorFactory's newConnector interface. Connectors could send async operators to this cpuExecutor to prevent occupying the driver executor. Pull Request resolved: facebookincubator#11861 Reviewed By: xiaoxmeng Differential Revision: D67231282 Pulled By: gggrace14 fbshipit-source-id: a92bb2c27ca26bf86a083ffea2a62b6c89231093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional argument, cpuExecutor, to the ConnectorFactory's
newConnector interface. Connectors could send async operators to this
cpuExecutor to prevent occupying the driver executor.