feat: Add Spark json_array_length function #11946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangGuangxin
force-pushed
the
feat_json_array_length
branch
from
a971121 to
a5c0d3b
Compare
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
✅ Deploy Preview for meta-velox canceled.
|
WangGuangxin
requested review from
assignUser and
majetideepak
as code owners
PHILO-HE
reviewed
Dec 24, 2024
| struct JsonArrayLengthFunction { | ||
| VELOX_DEFINE_FUNCTION_TYPES(T); | ||
|
|
||
| FOLLY_ALWAYS_INLINE bool call(int32_t& len, const arg_type<Json>& json) { |
There was a problem hiding this comment.
Suggestion:
Change const arg_type<Json>& to const arg_type<Varchar>& and remove the above corresponding header.
I think JsonType is just for presto.
rui-mo
changed the title
rui-mo
reviewed
Jan 8, 2025
rui-mo
reviewed
Jan 10, 2025
WangGuangxin
force-pushed
the
feat_json_array_length
branch
from
75dc918 to
dbd4e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'json_array_length' functions of Presto and Spark are similar, however
Presto returns int64_t, while Spark returns int32_t. In this PR, the
'JsonArrayLengthFunction' implementation is extracted to 'velox/functions/lib'
and registered with differenct return types for Presto and Spark.
Spark doc: https://spark.apache.org/docs/latest/api/sql/#json_array_length