feat(fuzzer): Allow bucket columns to overlap as sort columns in writer fuzzer #12007
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
4 similar comments
|
@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…er fuzzer (#12007) Summary: Allow bucket columns to overlap as sort columns by using some of the bucket columns as sort columns and generating the rest of the sort columns. Differential Revision: D67775105 Pulled By: HeidiHan0000
facebook-github-bot
force-pushed
the
WriterFuzzer-bucket-and-sort-by-same-col
branch
from
e19c9d7 to
fe7d648
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67775105 |
| auto [sortColumns, offset] = | ||
| generateSortColumns(3, names, types, bucketColumns); | ||
| sortColumnOffset -= offset; |
There was a problem hiding this comment.
A more straightforward way I can think of is keep the original code which generates the independentSortColumns, and pick some columns from bucket columns, then merge those two together.
Is it doable?
Allow bucket columns to overlap as sort columns by using some of the bucket columns as sort columns and generating the rest of the sort columns.