Move velox_aggregation_fuzzer_test and spark_aggregation_fuzzer_test to the fuzzer directory #8007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
929a278 to
80f6680
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 13, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: D52106081 fbshipit-source-id: 1d91c8a5c017b185b2d194184f90a8ca435d093c
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
80f6680 to
8a53041
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 13, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: D52106081 fbshipit-source-id: aa97ff57497da00409c3b65802c104301dbc9cb2
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
8a53041 to
95c974d
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 13, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: D52106081 fbshipit-source-id: 74341a37c42303739fce2df28d00e1158117dadc
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: https://internalfb.com/D52106081 fbshipit-source-id: 542862734bf27e9f14799d5c52a03007599244e0
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: https://internalfb.com/D52106081 fbshipit-source-id: 351955bf622baeef398d704cc49328522ca5e056
|
Hi @kgpai, I'm moving the target of velox_aggregation_fuzzer_test and spark_aggregation_fuzzer_test in this PR. I updated dist_compile.yml and scheduled.yml to use the new paths. But the CI job failed with the following error (https://github.com/facebookincubator/velox/actions/runs/7202009747/job/19620662750?pr=8007) Do you know what I'm missing here? |
kgpai
reviewed
Dec 14, 2023
| @@ -86,6 +86,7 @@ endif() | |||
| if(${VELOX_BUILD_TESTING}) | |||
| add_subdirectory(tests) | |||
| add_subdirectory(coverage) | |||
| add_subdirectory(fuzzer) | |||
There was a problem hiding this comment.
I think this should be in the functions cmake file and not prestosql..
There was a problem hiding this comment.
NVM, this path seems correct.
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
95c974d to
3abaaa2
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: D52106081 fbshipit-source-id: b48fb7b5fd35e00c0edd7e5e8034216224e42ea3
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
3abaaa2 to
9d040b5
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: D52106081 fbshipit-source-id: c319f2461912769f1cf7a5a792d93b38a67cb552
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: https://internalfb.com/D52106081 fbshipit-source-id: cc68f293dc4e0124e81cf9f31357c49cd4e7bebe
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: https://internalfb.com/D52106081 fbshipit-source-id: 3d79095ff76085f72abe08490ceb2ebd7e33db89
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 14, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: Pull Request resolved: facebookincubator#8007 This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Differential Revision: https://internalfb.com/D52106081 fbshipit-source-id: 8e102318af76b323e07ce7b9677dd53bfcf414b4
kagamiori
force-pushed
the
export-D52106081
branch
from
9d040b5 to
f7ec5c8
Compare
kagamiori
force-pushed
the
export-D52106081
branch
from
25f9418 to
58a0edb
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 15, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
force-pushed
the
export-D52106081
branch
from
58a0edb to
4b09343
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 15, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 15, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 15, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
force-pushed
the
export-D52106081
branch
from
4b09343 to
eca65cb
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
force-pushed
the
export-D52106081
branch
from
eca65cb to
e52b5d0
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
force-pushed
the
export-D52106081
branch
from
e52b5d0 to
660a02a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
force-pushed
the
export-D52106081
branch
from
660a02a to
fa6c9f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52106081 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Dec 19, 2023
…to the fuzzer directory (facebookincubator#8007) Summary: This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer. This is part of facebookincubator#7754. Reviewed By: mbasmanova Differential Revision: D52106081
|
Scheduled aggregation fuzzer jobs failed because they incorrectly check out the main branch instead of my branch. Join fuzzer, benchmark, and linux-build failed due to irrelevant errors. |
|
This pull request has been merged in 0f32527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves velox_aggregation_fuzzer_test to velox/functions/prestosql/fuzzer and moves spark_aggregation_fuzzer_test to velox/functions/sparksql/fuzzer.
This is part of #7754.
Differential Revision: D52106081