Add file-create-config to hive config and propagate to file sink #8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
xiaoxmeng
approved these changes
Dec 13, 2023
| @@ -595,6 +596,8 @@ uint32_t HiveDataSink::appendWriter(const HiveWriterId& id) { | |||
| setMemoryReclaimers(writerInfo_.back().get()); | |||
|
|
|||
| dwio::common::WriterOptions options; | |||
| const auto connectorSessionProperties = | |||
There was a problem hiding this comment.
s/const auto connectorSessionProperties/const auto* connectorSessionProperties/
tanjialiang
force-pushed
the
tw_write_config
branch
3 times, most recently
from
c629936 to
28b3406
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
force-pushed
the
tw_write_config
branch
from
28b3406 to
e82c7fa
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang merged this pull request in 62f20e2. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us to specify the write file create options through hive config or session properties.