Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly experimental job to run Aggregation Fuzzer with --enable_sorted_aggregations #8062

Closed
wants to merge 1 commit into from

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Dec 14, 2023

Adds experimental GA job to test out fuzzer runs with flags that are not yet stable (e.g --enable_sorted_aggregations). This will run in Github Actions tab, and will be available as 'experimental' job : https://github.com/facebookincubator/velox/actions
This job can be triggered manually at any time.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6a138d4
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/657b8ee8591c3100090f3e92

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2023
@kgpai kgpai force-pushed the experimental_runs branch from ae8593d to 1fded68 Compare December 14, 2023 22:52
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you update PR description to explain what this job does, how often it runs and where to check out the status?

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai kgpai changed the title Add experimental jobs. Add nightly experimental job to run Aggregation Fuzzer with --enable_sorted_aggregations Dec 14, 2023
@kgpai kgpai force-pushed the experimental_runs branch from 1fded68 to 6a138d4 Compare December 14, 2023 23:25
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 6459c07.

Copy link

Conbench analyzed the 1 benchmark run on commit 6459c077.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants