Fix outputBytes/Rows/Batches stats for PartitionedOutput #8072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Dec 15, 2023
spershin
reviewed
Dec 15, 2023
Comment on lines
+194
to
+197
| taskId, i, pool(), eagerFlush_, [&](uint64_t bytes, uint64_t rows) { | ||
| auto lockedStats = stats_.wlock(); | ||
| lockedStats->addOutputVector(bytes, rows); | ||
| })); |
There was a problem hiding this comment.
Is this ok to capture this in a lambda?
Could that lead to crashes when this gets destroyed and the callback called?
There was a problem hiding this comment.
Should be Ok since all operations are synchronous.
mbasmanova
force-pushed
the
fix-po-stats
branch
from
30f9e31 to
5130665
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 0152a05. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartitionedOutput operator used to report outputBytes/Rows/Batches the same as
inputBytes/Rows/Batches. With this change it reports outputBytes as number of
serialized bytes, outputRows the same as inputRows and outputBatches as number
of serialized pages produced. This helps get an accurate picture while debugging
issues with Exchange.