Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join fuzzer to experimental jobs #8319

Closed

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Jan 10, 2024

This will allow us to run experimental fuzzer on an ad-hoc basis against any branch.
Also fixes the path of the spark fuzzer artifacts.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit bbb60e0
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/659f1ad4770a0f0008be7043

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2024
@kgpai kgpai requested a review from mbasmanova January 10, 2024 01:36
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai kgpai requested a review from kagamiori January 10, 2024 01:37
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In the future, please, create a separate PR for each change.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai kgpai force-pushed the add_join_fuzzer_experimental branch 2 times, most recently from 6eda736 to b11af3a Compare January 10, 2024 20:05
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai kgpai force-pushed the add_join_fuzzer_experimental branch from b11af3a to bbb60e0 Compare January 10, 2024 22:31
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 2ceeca3.

Copy link

Conbench analyzed the 1 benchmark run on commit 2ceeca3e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

liujiayi771 pushed a commit to liujiayi771/velox that referenced this pull request Jan 16, 2024
Summary:
This will allow us to run experimental fuzzer on an ad-hoc basis against any branch.
Also fixes the path of the spark fuzzer artifacts.

Pull Request resolved: facebookincubator#8319

Reviewed By: mbasmanova

Differential Revision: D52646532

Pulled By: kgpai

fbshipit-source-id: 4d341c142a1aadcdfce6d9a145f1d208c0a3941d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants