Add support for Aggregate signatures in PyVelox and Signatures.py #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kgpai
force-pushed
the
bias_aggregation_fuzzer
branch
from
94c2977 to
488c980
Compare
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kagamiori
approved these changes
Mar 22, 2024
assignUser
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
LGTM I can rebase #9191 on this and prepare the actual sig checking too
kgpai
force-pushed
the
bias_aggregation_fuzzer
branch
from
488c980 to
a8e160a
Compare
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
force-pushed
the
bias_aggregation_fuzzer
branch
from
a8e160a to
3a461c0
Compare
kgpai
force-pushed
the
bias_aggregation_fuzzer
branch
from
3a461c0 to
8e2a32e
Compare
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Apr 4, 2024
…cebookincubator#9104) Summary: **What** This PR adds support for aggregate signatures in PyVelox and export these signatures using signature.py **Why** Support for aggregate signatures was missing previously in our biasing logic to make sure that changes in aggregate functions are backwards compatible. This first PR adds support for these aggregate signatures so that we can use them to track changes in aggregate signatures across commits. A subsequent PR will add support for biasing and erroring if we detect compatible/incompatible changes with newly added or modified aggregates. Pull Request resolved: facebookincubator#9104 Reviewed By: kagamiori Differential Revision: D54977056 Pulled By: kgpai fbshipit-source-id: aff940ff3b7b7eca2b825f67d3c6de2b10a0baad
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cebookincubator#9104) Summary: **What** This PR adds support for aggregate signatures in PyVelox and export these signatures using signature.py **Why** Support for aggregate signatures was missing previously in our biasing logic to make sure that changes in aggregate functions are backwards compatible. This first PR adds support for these aggregate signatures so that we can use them to track changes in aggregate signatures across commits. A subsequent PR will add support for biasing and erroring if we detect compatible/incompatible changes with newly added or modified aggregates. Pull Request resolved: facebookincubator#9104 Reviewed By: kagamiori Differential Revision: D54977056 Pulled By: kgpai fbshipit-source-id: aff940ff3b7b7eca2b825f67d3c6de2b10a0baad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for aggregate signatures in PyVelox and export these signatures using signature.py
Why
Support for aggregate signatures was missing previously in our biasing logic to make sure that changes in aggregate functions are backwards compatible. This first PR adds support for these aggregate signatures so that we can use them to track changes in aggregate signatures across commits. A subsequent PR will add support for biasing and erroring if we detect compatible/incompatible changes with newly added or modified aggregates.