-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent cache write from exceeding IOV_MAX #9438
Conversation
This pull request was exported from Phabricator. Differential Revision: D55941557 |
✅ Deploy Preview for meta-velox canceled.
|
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
This is a very long lasting bug. Thanks @zacw7 for working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacw7 thanks for the update % minors
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacw7 LGTM. Please also run this patch in interactive cluster before land. Thanks!
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
@zacw7 Great fix. Will be great if you can add error logs that we see now, which will no longer appear anymore. Also I assume this will translate to better cache hit rate? |
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557
This pull request was exported from Phabricator. Differential Revision: D55941557 |
This pull request was exported from Phabricator. Differential Revision: D55941557 |
This pull request has been merged in 8d09dc9. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…#9438)" (facebookincubator#9722) Summary: This reverts commit 8d09dc9. Pull Request resolved: facebookincubator#9722 Reviewed By: amitkdutta Differential Revision: D57004604 Pulled By: zacw7 fbshipit-source-id: e792ca6ecb376ad8a95d8ce3de819c7faeac5e0a
Summary: Pull Request resolved: facebookincubator#9438 Reviewed By: xiaoxmeng Differential Revision: D55941557 fbshipit-source-id: eb478af2e8b6eb10f9ed338222c424d4805fe005
…#9438)" (facebookincubator#9722) Summary: This reverts commit 8d09dc9. Pull Request resolved: facebookincubator#9722 Reviewed By: amitkdutta Differential Revision: D57004604 Pulled By: zacw7 fbshipit-source-id: e792ca6ecb376ad8a95d8ce3de819c7faeac5e0a
Differential Revision: D55941557